List:Commits« Previous MessageNext Message »
From:Alfranio Correia Date:January 31 2011 9:23am
Subject:Re: bzr commit into mysql-trunk branch (alfranio.correia:3527) Bug#57873
View as plain text  
Hi Libing,

Thank you for the review.

On 01/31/2011 08:42 AM, anders wrote:
> Hi Alfranio,
> 
> Great work!
> Please find my review comments below.
> 
> STATUS
> ------
>  
>   Not Approved.
> 
> REQUIRED CHANGES
> ----------------
> RC1. 
> +    13 + table_name_len +                       // "INTO TABLE `table`" 
> It should be table_name_len * 2.

I think this is not necessary because table_name is already quoted and its
length includes the quote characters.

Cheers.

> 
> 
> REQUESTS
> --------
> 
> SUGGESTIONS
> -----------
> 
Thread
bzr commit into mysql-trunk branch (alfranio.correia:3527) Bug#57873Alfranio Correia19 Jan
  • Re: bzr commit into mysql-trunk branch (alfranio.correia:3527)Bug#57873anders31 Jan
    • Re: bzr commit into mysql-trunk branch (alfranio.correia:3527) Bug#57873Alfranio Correia31 Jan
      • Re: bzr commit into mysql-trunk branch (alfranio.correia:3527)Bug#57873anders31 Jan
  • Re: bzr commit into mysql-trunk branch (alfranio.correia:3527)Bug#57873anders1 Feb
  • Re: bzr commit into mysql-trunk branch (alfranio.correia:3527) Bug#57873Luís Soares1 Mar