Re: bzr commit into mysql-trunk branch (alfranio.correia:3527) Bug#57873

[Alfranio Correia]

Hi Libing,

Thank you for the review.

On 01/31/2011 08:42 AM, anders wrote:
> Hi Alfranio,
> 
> Great work!
> Please find my review comments below.
> 
> STATUS
> ------
>  
>   Not Approved.
> 
> REQUIRED CHANGES
> ----------------
> RC1. 
> +    13 + table_name_len +                       // "INTO TABLE `table`" 
> It should be table_name_len * 2.

I think this is not necessary because table_name is already quoted and its
length includes the quote characters.

Cheers.

> 
> 
> REQUESTS
> --------
> 
> SUGGESTIONS
> -----------
>