List:Commits« Previous MessageNext Message »
From:Sergey Vojtovich Date:January 28 2011 2:51pm
Subject:Re: bzr commit into mysql-5.1 branch (Dmitry.Shulga:3564) Bug#57450
View as plain text  
Hi Dmitry,

that's too easy:
I run "mysql".
I get "mysql> " prompt.
I press "Ctrl-d".
I get "Segmentation fault".

Regards,
Sergey

On Fri, Jan 28, 2011 at 08:17:33PM +0600, Dmitry Shulga wrote:
> Hi Sergey.
> 
> > Hi Dmitry,
> > 
> > the patch looks nice - I like this idea of moving "truncated" flag
> > to line buffer structure. But please find comments inline...
> > 
> >> +    if (!line)
> >>     {
> >> -      status.exit_status=0;
> >> +      if (status.line_buff->error)
> >> +        status.exit_status= 1;
> >> +      else
> >> +        status.exit_status= 0;
> >>       break;
> >>     }
> > What if status.line_buff is NULL here?
> I don't see how can a status.line_buff have a NULL value in this place. If you have a
> test case where status.line_buff have a NULL value 
> please add new bug report.

...skip...

Regards,
Sergey
-- 
Sergey Vojtovich <svoj@stripped>
MySQL AB, Software Engineer
Izhevsk, Russia, www.mysql.com
Thread
bzr commit into mysql-5.1 branch (Dmitry.Shulga:3564) Bug#57450Dmitry Shulga20 Jan
  • Re: bzr commit into mysql-5.1 branch (Dmitry.Shulga:3564) Bug#57450Sergey Vojtovich21 Jan
    • Re: bzr commit into mysql-5.1 branch (Dmitry.Shulga:3564) Bug#57450Dmitry Shulga28 Jan
      • Re: bzr commit into mysql-5.1 branch (Dmitry.Shulga:3564) Bug#57450Sergey Vojtovich28 Jan