List:Commits« Previous MessageNext Message »
From:marko.makela Date:January 27 2011 8:21am
Subject:bzr push into mysql-trunk-innodb branch (marko.makela:3461 to 3463)
View as plain text  
 3463 Marko Mäkelä	2011-01-27 [merge]
      Merge mysql-5.5-innodb to mysql-trunk-innodb.

    modified:
      storage/innobase/ibuf/ibuf0ibuf.c
 3462 Marko Mäkelä	2011-01-27
      lock_unlock_table_autoinc(): Relax a debug assertion that was added in
      bzr revision-id marko.makela@stripped.
      This function can be called for XA PREPARED transactions, after all.

    modified:
      storage/innobase/lock/lock0lock.c
 3461 Marko Mäkelä	2011-01-26 [merge]
      Merge mysql-5.5-innodb to mysql-trunk-innodb.

    modified:
      storage/innobase/row/row0upd.c
=== modified file 'storage/innobase/ibuf/ibuf0ibuf.c'
--- a/storage/innobase/ibuf/ibuf0ibuf.c	revid:marko.makela@stripped081028-v3rublf9e9dtedm0
+++ b/storage/innobase/ibuf/ibuf0ibuf.c	revid:marko.makela@strippedfavguz71spq
@@ -2585,23 +2585,6 @@ ibuf_contract_ext(
 
 	if (UNIV_UNLIKELY(ibuf->empty)
 	    && UNIV_LIKELY(!srv_shutdown_state)) {
-ibuf_is_empty:
-
-#if 0 /* TODO */
-		if (srv_shutdown_state) {
-			/* If the insert buffer becomes empty during
-			shutdown, note it in the system tablespace. */
-
-			trx_sys_set_ibuf_format(TRX_SYS_IBUF_EMPTY);
-		}
-
-		/* TO DO: call trx_sys_set_ibuf_format() at startup
-		and whenever ibuf_use is changed to allow buffered
-		delete-marking or deleting.  Never downgrade the
-		stamped format except when the insert buffer becomes
-		empty. */
-#endif
-
 		return(0);
 	}
 
@@ -2631,7 +2614,7 @@ ibuf_is_empty:
 		mtr_commit(&mtr);
 		btr_pcur_close(&pcur);
 
-		goto ibuf_is_empty;
+		return(0);
 	}
 
 	sum_sizes = ibuf_get_merge_page_nos(TRUE, btr_pcur_get_rec(&pcur),

=== modified file 'storage/innobase/lock/lock0lock.c'
--- a/storage/innobase/lock/lock0lock.c	revid:marko.makela@strippedm0
+++ b/storage/innobase/lock/lock0lock.c	revid:marko.makela@stripped
@@ -6121,8 +6121,10 @@ lock_unlock_table_autoinc(
 	ut_ad(!lock_mutex_own());
 	ut_ad(!trx_mutex_own(trx));
 	ut_ad(!trx->lock.wait_lock);
+	/* This can be invoked on NOT_STARTED, ACTIVE, PREPARED,
+	but not COMMITTED transactions. */
 	ut_ad(trx_state_eq(trx, TRX_STATE_NOT_STARTED)
-	      || trx_state_eq(trx, TRX_STATE_ACTIVE));
+	      || !trx_state_eq(trx, TRX_STATE_COMMITTED_IN_MEMORY));
 
 	/* This function is invoked for a running transaction by the
 	thread that is serving the transaction. Therefore it is not

Attachment: [text/bzr-bundle] bzr/marko.makela@oracle.com-20110127081906-7hcdqfavguz71spq.bundle
Thread
bzr push into mysql-trunk-innodb branch (marko.makela:3461 to 3463) marko.makela27 Jan