List:Commits« Previous MessageNext Message »
From:marko.makela Date:January 27 2011 8:12am
Subject:bzr commit into mysql-5.5-innodb branch (marko.makela:3294)
View as plain text  
#At file:///home/marko/innobase/dev/mysql2a/5.5-innodb/ based on revid:marko.makela@stripped73hj98x1orek

 3294 Marko Mäkelä	2011-01-27
      ibuf_contract_ext(): Remove an #if 0 section of code
      that refers to trx_sys_set_ibuf_format().
      Change buffer format tagging was never implemented.

    modified:
      storage/innobase/ibuf/ibuf0ibuf.c
=== modified file 'storage/innobase/ibuf/ibuf0ibuf.c'
--- a/storage/innobase/ibuf/ibuf0ibuf.c	revid:marko.makela@stripped80252-vlp173hj98x1orek
+++ b/storage/innobase/ibuf/ibuf0ibuf.c	revid:marko.makela@strippediobnw0wf1q
@@ -2585,23 +2585,6 @@ ibuf_contract_ext(
 
 	if (UNIV_UNLIKELY(ibuf->empty)
 	    && UNIV_LIKELY(!srv_shutdown_state)) {
-ibuf_is_empty:
-
-#if 0 /* TODO */
-		if (srv_shutdown_state) {
-			/* If the insert buffer becomes empty during
-			shutdown, note it in the system tablespace. */
-
-			trx_sys_set_ibuf_format(TRX_SYS_IBUF_EMPTY);
-		}
-
-		/* TO DO: call trx_sys_set_ibuf_format() at startup
-		and whenever ibuf_use is changed to allow buffered
-		delete-marking or deleting.  Never downgrade the
-		stamped format except when the insert buffer becomes
-		empty. */
-#endif
-
 		return(0);
 	}
 
@@ -2631,7 +2614,7 @@ ibuf_is_empty:
 		mtr_commit(&mtr);
 		btr_pcur_close(&pcur);
 
-		goto ibuf_is_empty;
+		return(0);
 	}
 
 	sum_sizes = ibuf_get_merge_page_nos(TRUE, btr_pcur_get_rec(&pcur),

Attachment: [text/bzr-bundle] bzr/marko.makela@oracle.com-20110127081200-xib4soiobnw0wf1q.bundle
Thread
bzr commit into mysql-5.5-innodb branch (marko.makela:3294) marko.makela27 Jan