From: Joerg Bruehe
Date: January 24 2011 10:55am
Subject: Re: bzr commit into mysql-5.1 branch (Anders.Song:3559) Bug#58546
List-Archive: http://lists.mysql.com/commits/129423
Message-Id: <4D3D5ABA.10406@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Hi!


anders wrote:
> Hi Joerg,
>=20
> [snip]
>>> =3D=3D=3D added file 'mysql-test/include/restart_slave_sql.inc'
>>> --- a/mysql-test/include/restart_slave_sql.inc	1970-01-01 00:00:00 +0=
000
>>> +++ b/mysql-test/include/restart_slave_sql.inc	2011-01-17 22:44:07 +0=
000
>>> @@ -0,0 +1,43 @@
>>> [[...]]
>>> \ No newline at end of file
>> I doubt this should really be so.
> The line "\ No newline at end of file" is not in the file. It is
> generated by bzr diff if there is no '\n' in the last line.

I know.
I meant: I doubt the file should really not have a newline at its end.


> [snip]
>>> =3D=3D=3D modified file 'sql/slave.cc'
>>> --- a/sql/slave.cc	2010-11-30 23:32:51 +0000
>>> +++ b/sql/slave.cc	2011-01-17 22:44:07 +0000
>>> @@ -408,17 +408,6 @@ int terminate_slave_threads(Master_info*
>> This is the first change to this source file in 2011, but it doesn't
>> include a change of the copyright year. This must be wrong.
> hmm, I didn't know it is my business.
> I will check with Luis and fix it soon.
> Thanks!

Thanks for fixing - may save us some "showstopper" actions when it is
detected later.


Regards,
J=F6rg

--=20
Joerg Bruehe,  MySQL Build Team,  joerg.bruehe@stripped
               (+49 30) 417 01 487
ORACLE Deutschland B.V. & Co. KG,   Komturstrasse 18a,   D-12099 Berlin
Geschaeftsfuehrer: Juergen Kunz, Marcel v.d. Molen, Alexander v.d. Ven
Amtsgericht Muenchen: HRA 95603