List:Commits« Previous MessageNext Message »
From:anders Date:January 22 2011 6:49am
Subject:Re: bzr commit into mysql-5.1 branch (Anders.Song:3559) Bug#58546
View as plain text  
Hi Joerg,

[snip]
> > === added file 'mysql-test/include/restart_slave_sql.inc'
> > --- a/mysql-test/include/restart_slave_sql.inc	1970-01-01 00:00:00 +0000
> > +++ b/mysql-test/include/restart_slave_sql.inc	2011-01-17 22:44:07 +0000
> > @@ -0,0 +1,43 @@
> > [[...]]
> > \ No newline at end of file
> 
> I doubt this should really be so.
The line "\ No newline at end of file" is not in the file. It is
generated by bzr diff if there is no '\n' in the last line.
> 
[snip]
> > 
> > === modified file 'sql/slave.cc'
> > --- a/sql/slave.cc	2010-11-30 23:32:51 +0000
> > +++ b/sql/slave.cc	2011-01-17 22:44:07 +0000
> > @@ -408,17 +408,6 @@ int terminate_slave_threads(Master_info*
> 
> This is the first change to this source file in 2011, but it doesn't
> include a change of the copyright year. This must be wrong.
hmm, I didn't know it is my business.
I will check with Luis and fix it soon.
Thanks!
> 


-- 
Your Sincerely, 
Libing Song
==================================
MySQL Replication Team
Software Engineer


Email : Anders.Song@stripped
Skype : libing.song
MSN   : slb_database@stripped
Phone : +86 010-6505-4020 ext. 319
Mobile: +86 138-1144-2038
==================================

Thread
bzr commit into mysql-5.1 branch (Anders.Song:3559) Bug#58546Anders.Song18 Jan
  • Re: bzr commit into mysql-5.1 branch (Anders.Song:3559) Bug#58546Joerg Bruehe19 Jan
    • Re: bzr commit into mysql-5.1 branch (Anders.Song:3559) Bug#58546anders22 Jan
      • Re: bzr commit into mysql-5.1 branch (Anders.Song:3559) Bug#58546Joerg Bruehe24 Jan
        • Re: bzr commit into mysql-5.1 branch (Anders.Song:3559) Bug#58546anders24 Jan