List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:January 20 2011 1:42pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3514)
Bug#58026
View as plain text  
Hi Dmitry,

On 1/19/11 3:10 PM, Dmitry Shulga wrote:
> #At file:///Users/shulga/projects/mysql/5.1-bugteam-bug58026/ based on
> revid:davi.arnaut@stripped
>
>   3514 Dmitry Shulga	2011-01-19
>        Fixed bug#58026 - massive recursion and crash in regular expression
>        handling.
>
>        The problem was that parsing of nested regular expression involved
>        recursive calls. Such recursion didn't take into account the amount of
>        available stack space, which ended up leading to stack overflow crashes.

[...]

>
> === modified file 'sql/mysqld.cc'
> --- a/sql/mysqld.cc	2010-11-09 14:45:13 +0000
> +++ b/sql/mysqld.cc	2011-01-19 17:10:47 +0000
> @@ -3032,6 +3032,20 @@ sizeof(load_default_groups)/sizeof(load_
>   #endif
>
>
> +#ifndef EMBEDDED_LIBRARY
> +extern "C"
> +int
> +check_enough_stack_size()
> +{
> +  uchar stack_top;
> +
> +  return check_stack_overrun(current_thd, STACK_MIN_SIZE,
> +&stack_top);
> +  return 0;

Two return values. Also, this makes the function global, while what I 
sent makes the function specific to this compilation unit.

Regards,

Davi
Thread
bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3514) Bug#58026Dmitry Shulga19 Jan
  • Re: bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3514)Bug#58026Davi Arnaut20 Jan