List:Commits« Previous MessageNext Message »
From:Bjorn Munch Date:January 19 2011 9:53pm
Subject:Re: bzr commit into mysql-next-mr-bugfixing branch (guilhem.bichot:3260)
View as plain text  
On 19/01 21.14, Guilhem Bichot wrote:
>
> Maybe we could do a sql_print_warning() instead of DBUG_ASSERT(0); mtr 
> warns when it sees an unexpected warning, it marks the test as failed, 
> prints the warning on stderr, and returns 1 as exit code. I guess this 
> would be good enough?

I'm not familiar with all the context here, but just let me add a
comment from the perspective of mtr: yes, mtr will see an unexpected
warning in the server log and report the test as failed, but it has no
way of knowing what action from the test caused that warning. The test
will have run to its end.

If the server dies OTOH, test execution stops and mtr will also print
out the last statements executed before the crash.

- Bjorn
Thread
bzr commit into mysql-next-mr-bugfixing branch (guilhem.bichot:3260) Guilhem Bichot19 Jan
Re: bzr commit into mysql-next-mr-bugfixing branch (guilhem.bichot:3260)Davi Arnaut19 Jan
  • Re: bzr commit into mysql-next-mr-bugfixing branch (guilhem.bichot:3260)Guilhem Bichot19 Jan
    • Re: bzr commit into mysql-next-mr-bugfixing branch (guilhem.bichot:3260)Davi Arnaut19 Jan
      • Re: bzr commit into mysql-next-mr-bugfixing branch (guilhem.bichot:3260)Guilhem Bichot20 Jan
    • Re: bzr commit into mysql-next-mr-bugfixing branch (guilhem.bichot:3260)Bjorn Munch19 Jan
      • Re: bzr commit into mysql-next-mr-bugfixing branch (guilhem.bichot:3260)Davi Arnaut19 Jan