On 1/19/11 7:21 AM, Joerg Bruehe wrote:
> Hi all!
>
>
> Davi Arnaut wrote:
>> Hi Dmitry,
>>
>> On 1/18/11 5:17 AM, Dmitry Shulga wrote:
>>> #At file:///Users/shulga/projects/mysql/5.1-bugteam-bug58026/ based on
>>> revid:davi.arnaut@stripped
>>>
>>> 3514 Dmitry Shulga 2011-01-18
>>> Fixed bug#58026 - massive recursion and crash in regular
>>> expression
>>> handling.
>>>
>>> The problem was that parsing of nested regular expression involved
>>> recursive calls. Such recursion didn't take into account the
>>> amount of
>>> available stack space, which ended up leading to stack overflow
>>> crashes.
>>
>> Not approved, some comments below.
>
> In addition to Davi's objections to the contents, I want to point at the
> lack of copyright year changes.
Thanks for the heads up, but most of the files he changes do not even
have a copyright header. Some of the other changes do not even warrant a
copyright update. Nonetheless, I'll take a look once a final patch is ready.
Regards,
Davi
