List:Commits« Previous MessageNext Message »
From:Joerg Bruehe Date:January 19 2011 9:21am
Subject:Re: bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3514)
Bug#58026
View as plain text  
Hi all!


Davi Arnaut wrote:
> Hi Dmitry,
> 
> On 1/18/11 5:17 AM, Dmitry Shulga wrote:
>> #At file:///Users/shulga/projects/mysql/5.1-bugteam-bug58026/ based on
>> revid:davi.arnaut@stripped
>>
>>   3514 Dmitry Shulga    2011-01-18
>>        Fixed bug#58026 - massive recursion and crash in regular
>> expression
>>        handling.
>>
>>        The problem was that parsing of nested regular expression involved
>>        recursive calls. Such recursion didn't take into account the
>> amount of
>>        available stack space, which ended up leading to stack overflow
>> crashes.
> 
> Not approved, some comments below.

In addition to Davi's objections to the contents, I want to point at the
lack of copyright year changes.

Regards,
Jörg

-- 
Joerg Bruehe,  MySQL Build Team,  joerg.bruehe@stripped
               (+49 30) 417 01 487
ORACLE Deutschland B.V. & Co. KG,   Komturstrasse 18a,   D-12099 Berlin
Geschaeftsfuehrer: Juergen Kunz, Marcel v.d. Molen, Alexander v.d. Ven
Amtsgericht Muenchen: HRA 95603

Thread
bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3514) Bug#58026Dmitry Shulga18 Jan
  • Re: bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3514)Bug#58026Davi Arnaut18 Jan
    • Re: bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3514)Bug#58026Joerg Bruehe19 Jan
      • Re: bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3514)Bug#58026Davi Arnaut19 Jan