From: Joerg Bruehe
Date: January 19 2011 9:19am
Subject: Re: bzr commit into mysql-5.1 branch (Anders.Song:3559) Bug#58546
List-Archive: http://lists.mysql.com/commits/129149
Message-Id: <4D36ACA2.3020602@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Hi Anders!


Anders.Song@stripped wrote:
> #At file:///home/songlibing/bzrwork/wt3/mysql-5.1/ based on revid:vinay=
=2Efisrekar@stripped
>=20
>  3559 Anders.Song@stripped	2011-01-18
>       Bug#58546 test rpl_packet timeout failure sporadically on PB
>                  =20
>       [[...]]
>=20
>     added:
>       mysql-test/include/restart_slave_sql.inc
>       mysql-test/include/rpl_connection_master.inc
>       mysql-test/include/rpl_connection_slave.inc
>       mysql-test/include/rpl_connection_slave1.inc
>     modified:
>       mysql-test/suite/rpl/r/rpl_stop_slave.result
>       mysql-test/suite/rpl/t/rpl_packet.test
>       mysql-test/suite/rpl/t/rpl_stop_slave.test
>       sql/slave.cc
>       sql/sql_repl.cc
> =3D=3D=3D added file 'mysql-test/include/restart_slave_sql.inc'
> --- a/mysql-test/include/restart_slave_sql.inc	1970-01-01 00:00:00 +000=
0
> +++ b/mysql-test/include/restart_slave_sql.inc	2011-01-17 22:44:07 +000=
0
> @@ -0,0 +1,43 @@
> [[...]]
> \ No newline at end of file

I doubt this should really be so.

>=20
> =3D=3D=3D added file 'mysql-test/include/rpl_connection_master.inc'
> --- a/mysql-test/include/rpl_connection_master.inc	1970-01-01 00:00:00 =
+0000
> +++ b/mysql-test/include/rpl_connection_master.inc	2011-01-17 22:44:07 =
+0000
> @@ -0,0 +1,2 @@
> [[...]]
> \ No newline at end of file

Same here, ...

>=20
> =3D=3D=3D added file 'mysql-test/include/rpl_connection_slave.inc'
> --- a/mysql-test/include/rpl_connection_slave.inc	1970-01-01 00:00:00 +=
0000
> +++ b/mysql-test/include/rpl_connection_slave.inc	2011-01-17 22:44:07 +=
0000
> @@ -0,0 +1,2 @@
> [[...]]
> \ No newline at end of file

=2E.. here, ...

>=20
> =3D=3D=3D added file 'mysql-test/include/rpl_connection_slave1.inc'
> --- a/mysql-test/include/rpl_connection_slave1.inc	1970-01-01 00:00:00 =
+0000
> +++ b/mysql-test/include/rpl_connection_slave1.inc	2011-01-17 22:44:07 =
+0000
> @@ -0,0 +1,2 @@
> [[...]]
> \ No newline at end of file

=2E.. and here.

>=20
> =3D=3D=3D modified file 'mysql-test/suite/rpl/r/rpl_stop_slave.result'
> [[...]]
>=20
> =3D=3D=3D modified file 'mysql-test/suite/rpl/t/rpl_packet.test'
> [[...]]
>=20
> =3D=3D=3D modified file 'mysql-test/suite/rpl/t/rpl_stop_slave.test'
> [[...]]
>=20
> =3D=3D=3D modified file 'sql/slave.cc'
> --- a/sql/slave.cc	2010-11-30 23:32:51 +0000
> +++ b/sql/slave.cc	2011-01-17 22:44:07 +0000
> @@ -408,17 +408,6 @@ int terminate_slave_threads(Master_info*

This is the first change to this source file in 2011, but it doesn't
include a change of the copyright year. This must be wrong.

> [[...]]
>=20
> =3D=3D=3D modified file 'sql/sql_repl.cc'
> --- a/sql/sql_repl.cc	2010-07-26 09:56:30 +0000
> +++ b/sql/sql_repl.cc	2011-01-17 22:44:07 +0000
> @@ -21,6 +21,7 @@

Same as above.

> [[...]]
>=20

Regards,
J=F6rg

--=20
Joerg Bruehe,  MySQL Build Team,  joerg.bruehe@stripped
               (+49 30) 417 01 487
ORACLE Deutschland B.V. & Co. KG,   Komturstrasse 18a,   D-12099 Berlin
Geschaeftsfuehrer: Juergen Kunz, Marcel v.d. Molen, Alexander v.d. Ven
Amtsgericht Muenchen: HRA 95603