List:Commits« Previous MessageNext Message »
From:Joerg Bruehe Date:January 19 2011 9:03am
Subject:Re: bzr commit into mysql-5.1 branch (Li-Bing.Song:3559) Bug#58546
View as plain text  
Hi Li-Bing!


To me, your change seems to be incomplete in several formal aspects,
please see the notes below.


Jörg


Li-Bing.Song@stripped wrote:
> #At file:///home/songlibing/bzrwork/wt3/mysql-5.1/ based on
> revid:vinay.fisrekar@stripped
> 
>  3559 Li-Bing.Song@stripped	2011-01-18
>       Bug#58546 test rpl_packet timeout failure sporadically on PB
>                   
>       [[...]]
> 
>     added:
>       mysql-test/include/restart_slave_sql.inc
>       mysql-test/include/rpl_connection_master.inc
>       mysql-test/include/rpl_connection_slave.inc
>       mysql-test/include/rpl_connection_slave1.inc
>     modified:
>       mysql-test/suite/rpl/r/rpl_stop_slave.result
>       mysql-test/suite/rpl/t/rpl_packet.test
>       mysql-test/suite/rpl/t/rpl_stop_slave.test
>       sql/slave.cc
>       sql/sql_repl.cc
> === added file 'mysql-test/include/restart_slave_sql.inc'
> --- a/mysql-test/include/restart_slave_sql.inc	1970-01-01 00:00:00 +0000
> +++ b/mysql-test/include/restart_slave_sql.inc	2011-01-17 22:26:04 +0000
> @@ -0,0 +1,43 @@
> [[...]]
> \ No newline at end of file

I doubt this should really be so.

> 
> === added file 'mysql-test/include/rpl_connection_master.inc'
> --- a/mysql-test/include/rpl_connection_master.inc	1970-01-01 00:00:00 +0000
> +++ b/mysql-test/include/rpl_connection_master.inc	2011-01-17 22:26:04 +0000
> @@ -0,0 +1,2 @@
> [[...]]
> \ No newline at end of file

Same here ...,

> 
> === added file 'mysql-test/include/rpl_connection_slave.inc'
> --- a/mysql-test/include/rpl_connection_slave.inc	1970-01-01 00:00:00 +0000
> +++ b/mysql-test/include/rpl_connection_slave.inc	2011-01-17 22:26:04 +0000
> @@ -0,0 +1,2 @@
> [[...]]
> \ No newline at end of file

... here, ...

> 
> === added file 'mysql-test/include/rpl_connection_slave1.inc'
> --- a/mysql-test/include/rpl_connection_slave1.inc	1970-01-01 00:00:00 +0000
> +++ b/mysql-test/include/rpl_connection_slave1.inc	2011-01-17 22:26:04 +0000
> @@ -0,0 +1,2 @@
> [[...]]
> \ No newline at end of file

... and here.

> 
> === modified file 'mysql-test/suite/rpl/r/rpl_stop_slave.result'
> [[...]]
> 
> === modified file 'mysql-test/suite/rpl/t/rpl_packet.test'
> [[...]]
> 
> === modified file 'mysql-test/suite/rpl/t/rpl_stop_slave.test'
> [[...]]
> 
> === modified file 'sql/slave.cc'
> --- a/sql/slave.cc	2010-11-30 23:32:51 +0000
> +++ b/sql/slave.cc	2011-01-17 22:26:04 +0000
> @@ -408,17 +408,6 @@ int terminate_slave_threads(Master_info*

Last change was in 2010, and this one is 2011, so the copyright notice
must be updated.
This one is still an old "MySQL AB" one. :(

> [[...]]
>  
> 
> === modified file 'sql/sql_repl.cc'
> --- a/sql/sql_repl.cc	2010-07-26 09:56:30 +0000
> +++ b/sql/sql_repl.cc	2011-01-17 22:26:04 +0000
> @@ -21,6 +21,7 @@

Similar here (but I don't know what should become of "Sasha" who is
mentioned there).

>  [[...]]
> 


-- 
Joerg Bruehe,  MySQL Build Team,  joerg.bruehe@stripped
               (+49 30) 417 01 487
ORACLE Deutschland B.V. & Co. KG,   Komturstrasse 18a,   D-12099 Berlin
Geschaeftsfuehrer: Juergen Kunz, Marcel v.d. Molen, Alexander v.d. Ven
Amtsgericht Muenchen: HRA 95603

Thread
bzr commit into mysql-5.1 branch (Li-Bing.Song:3559) Bug#58546Li-Bing.Song18 Jan
  • Re: bzr commit into mysql-5.1 branch (Li-Bing.Song:3559) Bug#58546Joerg Bruehe19 Jan