List:Commits« Previous MessageNext Message »
From:Joerg Bruehe Date:January 19 2011 8:53am
Subject:Re: bzr commit into mysql-5.0 branch (Georgi.Kodinov:2895) Bug#52315
Bug#55755
View as plain text  
Joro,


several of your code changes are the first ones in 2011, and still they
don't include an update of the copyright year.
IMO, this must be done, ASAP - after all, we have showstopper bugs filed
about that.


Regards,
Jörg


Georgi Kodinov wrote:
> #At file:///Users/kgeorge/mysql/work/B55755-5.0/ based on
> revid:alexander.nozdrin@stripped
> 
>  2895 Georgi Kodinov	2011-01-17
>       Fixes for Bug #55755 and Bug #52315 part 2
>       
>       [[...]]
> 
>     modified:
>       configure.in
>       include/config-win.h
>       include/my_time.h
>       mysql-test/r/func_time.result
>       mysql-test/t/func_time.test
>       sql-common/my_time.c
>       sql/mysqld.cc
>       sql/set_var.cc
>       sql/sql_class.h
> === modified file 'configure.in'
> --- a/configure.in	2010-12-28 18:57:23 +0000
> +++ b/configure.in	2011-01-17 16:43:43 +0000

Surprisingly, this file doesn't have any copyright notice. No idea why,
and whether to change that or not.

> [[...]]
> 
> === modified file 'include/config-win.h'
> --- a/include/config-win.h	2009-07-31 19:22:02 +0000
> +++ b/include/config-win.h	2011-01-17 16:43:43 +0000

But this file has - it is still "2000 MySQL AB".

> [[...]]
> 
> === modified file 'include/my_time.h'
> --- a/include/my_time.h	2008-04-03 15:32:00 +0000
> +++ b/include/my_time.h	2011-01-17 16:43:43 +0000

Similar here: "2004-2005 MySQL AB".

> [[...]]
> 
> === modified file 'mysql-test/r/func_time.result'
> [[...]]
> 
> === modified file 'mysql-test/t/func_time.test'
> [[...]]
> 
> === modified file 'sql-common/my_time.c'
> --- a/sql-common/my_time.c	2009-09-17 15:10:30 +0000
> +++ b/sql-common/my_time.c	2011-01-17 16:43:43 +0000

Similar here: "2004-2006 MySQL AB".

> [[...]]
> 
> === modified file 'sql/mysqld.cc'
> --- a/sql/mysqld.cc	2010-12-28 18:57:23 +0000
> +++ b/sql/mysqld.cc	2011-01-17 16:43:43 +0000

An Oracle cpyright (correct), still at 2010 (wrong).

> [[...]]
> 
> === modified file 'sql/set_var.cc'
> --- a/sql/set_var.cc	2010-12-28 18:57:23 +0000
> +++ b/sql/set_var.cc	2011-01-17 16:43:43 +0000

Same here.

> [[...]]
> 
> === modified file 'sql/sql_class.h'
> --- a/sql/sql_class.h	2010-12-28 18:57:23 +0000
> +++ b/sql/sql_class.h	2011-01-17 16:43:43 +0000

Again.

> [[...]]
> 
> 

-- 
Joerg Bruehe,  MySQL Build Team,  joerg.bruehe@stripped
               (+49 30) 417 01 487
ORACLE Deutschland B.V. & Co. KG,   Komturstrasse 18a,   D-12099 Berlin
Geschaeftsfuehrer: Juergen Kunz, Marcel v.d. Molen, Alexander v.d. Ven
Amtsgericht Muenchen: HRA 95603

Thread
bzr commit into mysql-5.0 branch (Georgi.Kodinov:2895) Bug#52315 Bug#55755Georgi Kodinov17 Jan
  • Re: bzr commit into mysql-5.0 branch (Georgi.Kodinov:2895) Bug#52315Bug#55755Joerg Bruehe19 Jan
  • Re: bzr commit into mysql-5.0 branch (Georgi.Kodinov:2895)Bug#52315 Bug#55755Dmitry Lenev2 Feb