From: Joerg Bruehe
Date: January 19 2011 8:44am
Subject: Re: bzr commit into mysql-5.0 branch (daogang.qu:2895) Bug#58712
List-Archive: http://lists.mysql.com/commits/129141
Message-Id: <4D36A476.4070003@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit

Hi!


All your code changes are missing the copyright year update:

daogang.qu@stripped wrote:
> #At file:///home/daogang/bzrwork/bug58712/mysql-5.0/ based on revid:alexander.nozdrin@stripped
> 
>  2895 daogang.qu@stripped	2011-01-19
>       Bug #58712  GRANT ... IDENTIFIED BY password is not encrypted in the binary log
>       
>       The password is not encrypted in binary log for GRANT stmt.
>       
>       [[...]]
> 
>     modified:
>       mysql-test/r/grant.result
>       mysql-test/r/rpl_grant.result
>       mysql-test/r/rpl_openssl.result
>       mysql-test/r/rpl_sp.result
>       mysql-test/r/rpl_ssl.result
>       mysql-test/r/rpl_user.result
>       mysql-test/t/grant.test
>       mysql-test/t/rpl_user.test
>       sql/sql_acl.cc
>       sql/sql_lex.h
>       sql/sql_yacc.yy
> === modified file 'mysql-test/r/grant.result'
> [[...]]
> 
> === modified file 'mysql-test/r/rpl_grant.result'
> [[...]]
> 
> === modified file 'mysql-test/r/rpl_openssl.result'
> [[...]]
> 
> === modified file 'mysql-test/r/rpl_ssl.result'
> [[...]]
> 
> === modified file 'mysql-test/r/rpl_user.result'
> [[...]]
> 
> === modified file 'mysql-test/t/grant.test'
> [[...]]
> 
> === modified file 'mysql-test/t/rpl_user.test'
> [[...]]
> 
> === modified file 'sql/sql_acl.cc'
> --- a/sql/sql_acl.cc	2010-02-20 17:08:35 +0000
> +++ b/sql/sql_acl.cc	2011-01-19 06:12:05 +0000
> @@ -3050,6 +3050,61 @@ int mysql_table_grant(THD *thd, TABLE_LI
> [[...]]
The last change to this file was in 2010, and yours is in 2011.
You forgot to update the year in the copyright notice.

> 
> === modified file 'sql/sql_lex.h'
> --- a/sql/sql_lex.h	2009-05-06 13:06:32 +0000
> +++ b/sql/sql_lex.h	2011-01-19 06:12:05 +0000
> @@ -1169,11 +1169,13 @@ typedef struct st_lex : public Query_tab
> [[...]]
Same as above - 2009 to 2011, the copyright year must be updated.

> 
> === modified file 'sql/sql_yacc.yy'
> --- a/sql/sql_yacc.yy	2010-02-20 17:08:35 +0000
> +++ b/sql/sql_yacc.yy	2011-01-19 06:12:05 +0000
> @@ -10357,16 +10357,18 @@ grant:
> [[...]]
Again.

> 


-- 
Joerg Bruehe,  MySQL Build Team,  joerg.bruehe@stripped
               (+49 30) 417 01 487
ORACLE Deutschland B.V. & Co. KG,   Komturstrasse 18a,   D-12099 Berlin
Geschaeftsfuehrer: Juergen Kunz, Marcel v.d. Molen, Alexander v.d. Ven
Amtsgericht Muenchen: HRA 95603