List:Commits« Previous MessageNext Message »
From:Luis Soares Date:January 18 2011 12:09pm
Subject:bzr commit into mysql-trunk branch (luis.soares:3522) Bug#47557
View as plain text  
#At file:///home/lsoares/Workspace/bzr/work/bugfixing/47557/mysql-trunk/ based on revid:tor.didriksen@stripped

 3522 Luis Soares	2011-01-18
      BUG#47557: mysqlbinlog -v should output 'limit 1' for update and 
                 delete row events
      
      mysqlbinlog -v shows pseudo-SQL statements, reconstructed out of
      the rows, as comments. However, --verbose description mentions that
      it reconstructs SQL statements, when in fact these are SQL-like
      statements and not, 100% valid, SQL instructions.
      
      We fix this by replacing "SQL" with "pseudo-SQL" in mysqlbinlog 
      help text (pseudo-SQL is actually the term used in the user
      manual).

    modified:
      client/mysqlbinlog.cc
=== modified file 'client/mysqlbinlog.cc'
--- a/client/mysqlbinlog.cc	2011-01-16 04:02:29 +0000
+++ b/client/mysqlbinlog.cc	2011-01-18 12:09:03 +0000
@@ -994,7 +994,7 @@ static struct my_option my_long_options[
     /* 'unspec' is not mentioned because it is just a placeholder. */
    "Determine when the output statements should be base64-encoded BINLOG "
    "statements: 'never' disables it and works only for binlogs without "
-   "row-based events; 'decode-rows' decodes row events into commented SQL "
+   "row-based events; 'decode-rows' decodes row events into commented pseudo-SQL "
    "statements if the --verbose option is also given; 'auto' prints base64 "
    "only when necessary (i.e., for row-based events and format description "
    "events).  If no --base64-output[=name] option is given at all, the "
@@ -1150,7 +1150,7 @@ static struct my_option my_long_options[
   {"user", 'u', "Connect to the remote server as username.",
    &user, &user, 0, GET_STR_ALLOC, REQUIRED_ARG, 0, 0, 0, 0,
    0, 0},
-  {"verbose", 'v', "Reconstruct SQL statements out of row events. "
+  {"verbose", 'v', "Reconstruct pseudo-SQL statements out of row events. "
                    "-v -v adds comments on column data types.",
    0, 0, 0, GET_NO_ARG, NO_ARG, 0, 0, 0, 0, 0, 0},
   {"version", 'V', "Print version and exit.", 0, 0, 0, GET_NO_ARG, NO_ARG, 0,


Attachment: [text/bzr-bundle] bzr/luis.soares@oracle.com-20110118120903-0vk91gi7j4ytfknx.bundle
Thread
bzr commit into mysql-trunk branch (luis.soares:3522) Bug#47557Luis Soares18 Jan