List:Commits« Previous MessageNext Message »
From:Tor Didriksen Date:January 13 2011 3:08pm
Subject:Re: bzr commit into mysql-trunk branch (tor.didriksen:3498) Bug#59241
View as plain text  
On 2011-01-13 15:45, Olav Sandstaa wrote:
> Hi Tor,
>
> The patch looks good. Thanks for adding copy constructor and 
> assignment operators and a google test for this.
>
> One minor comments that you should feel free to ignore:
>
> * In Item_func_int_div::val_int(): We have now five my_decimal 
> objects, I think tree of these are just needed for having as input 
> arguments to the various calls and are never used after the calls. So 
> the following my_decimal objects:
>
>      my_decimal value0, value1, tmp;
>
>    could probably be replaced by just on my_decimal object?

indeed.

-- didrik

Thread
bzr commit into mysql-trunk branch (tor.didriksen:3498) Bug#59241Tor Didriksen13 Jan
  • Re: bzr commit into mysql-trunk branch (tor.didriksen:3498) Bug#59241Jorgen Loland13 Jan
    • Re: bzr commit into mysql-trunk branch (tor.didriksen:3498) Bug#59241Tor Didriksen13 Jan
  • Re: bzr commit into mysql-trunk branch (tor.didriksen:3498) Bug#59241Olav Sandstaa13 Jan
    • Re: bzr commit into mysql-trunk branch (tor.didriksen:3498) Bug#59241Tor Didriksen13 Jan