List:Commits« Previous MessageNext Message »
From:Luis Soares Date:January 13 2011 2:31pm
Subject:bzr commit into mysql-5.5 branch (luis.soares:3240) Bug#59444
View as plain text  
#At file:///home/lsoares/Workspace/bzr/work/bugfixing/59444/mysql-5.5/ based on revid:luis.soares@stripped

 3240 Luis Soares	2011-01-13
      BUG#59444
      
      Added comments to rpl_show_relaylog_events as requested by 
      reviewer.

    modified:
      mysql-test/extra/rpl_tests/rpl_show_relaylog_events.inc
=== modified file 'mysql-test/extra/rpl_tests/rpl_show_relaylog_events.inc'
--- a/mysql-test/extra/rpl_tests/rpl_show_relaylog_events.inc	2011-01-13 12:21:57 +0000
+++ b/mysql-test/extra/rpl_tests/rpl_show_relaylog_events.inc	2011-01-13 14:31:37 +0000
@@ -8,6 +8,12 @@ INSERT INTO t1 VALUES (1);
 INSERT INTO t1 VALUES (2);
 INSERT INTO t1 VALUES (3);
 
+# PART I
+#
+# SHOWs contents of binary logs on the master and both, binary and
+# relay logs, on the slave.
+#
+
 --let $is_relay_log= 0
 --let $binlog_file= query_get_value(SHOW MASTER STATUS, File, 1)
 --source extra/rpl_tests/rpl_show_log_events_with_varying_options.inc
@@ -20,8 +26,21 @@ INSERT INTO t1 VALUES (3);
 --let $binlog_file= query_get_value(SHOW SLAVE STATUS, Relay_Log_File, 1)
 --source extra/rpl_tests/rpl_show_log_events_with_varying_options.inc
 
-FLUSH LOGS;
+#
+# PART II
+#
+# Although this second part of the test may seem redudant it is
+# actually needed to assert that SHOW RELAYLOG EVENTS works properly
+# with respect to the ordering of the relay log in relay-log.index. 
+#
+# If no file is specified with "IN" then first relay log file in
+# relay-log.index (ie, the oldest one) should be picked and its
+# contents displayed. The same happens for SHOW BINLOG EVENTS, so we
+# show them both. All in all, this is the reason for re-assert after
+# MASTER and SLAVE's FLUSH LOGS operations.
+#
 
+FLUSH LOGS;
 -- connection master
 FLUSH LOGS;
 DROP TABLE t1;


Attachment: [text/bzr-bundle] bzr/luis.soares@oracle.com-20110113143137-junneft03tkwtbn7.bundle
Thread
bzr commit into mysql-5.5 branch (luis.soares:3240) Bug#59444Luis Soares13 Jan