From: Jon Olav Hauglid
Date: January 6 2011 1:45pm
Subject: Re: bzr commit into mysql-trunk branch (tor.didriksen:3465) Bug#59309
List-Archive: http://lists.mysql.com/commits/128079
Message-Id: <4D25C779.5040203@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

Patch approved.
One minor comment below.

On 01/06/2011 02:03 PM, Tor Didriksen wrote:
>   3465 Tor Didriksen	2011-01-06
>        Bug #59309  Cleanup MDL - THD interface

> === modified file 'sql/sql_class.h'

> +  /**
> +    A callback to the server internals that is used to address
> +    special cases of the locking protocol.
> +    Invoked when acquiring an exclusive lock, for each thread that
> +    has a conflicting shared metadata lock.
> +
> +    This function:
> +    - aborts waiting of the thread on a data lock, to make it notice
> +      the pending exclusive lock and back off.
> +    - if the thread is an INSERT DELAYED thread, sends it a KILL
> +      signal to terminate it.
> +
> +    @note This function does not wait for the thread to give away its
> +          locks. Waiting is done outside for all threads at once.
> +
> +    @param in_use               The thread to wake up

This comment should be updated to reflect that in_use has changed.

> +    @param needs_thr_lock_abort Indicates that to wake up thread
> +                                this call needs to abort its waiting
> +                                on table-level lock.
> +
> +    @retval  TRUE  if the thread was woken up
> +    @retval  FALSE otherwise.
> +   */
> +  virtual bool notify_shared_lock(MDL_context_owner *ctx_in_use,
> +                                  bool needs_thr_lock_abort);

Thanks,

--- Jon Olav