List:Commits« Previous MessageNext Message »
From:Jorgen Loland Date:January 5 2011 11:40am
Subject:bzr commit into mysql-trunk-bugfixing branch (jorgen.loland:3475) Bug#58837
View as plain text  
#At file:///export/home/jl208045/mysql/mysql-trunk-bugfixing/ based on revid:dao-gang.qu@stripped

 3475 Jorgen Loland	2011-01-05
      BUG#58837: ICP crash or valgrind error due to uninitialized 
                 value in innobase_index_cond
      
      The problem was that ICP pushed a condition to an InnoDB 
      table accessed through the primary key, and handler::end_range 
      was not initialized in this case. This problem emerged now 
      because ICP on InnoDB primary index has recently been enabled.
      
      Test case will be added by bug 59307
     @ sql/handler.h
        Initialize handler::end_range in ha_rnd_init() and ha_rnd_end()

    modified:
      sql/handler.h
=== modified file 'sql/handler.h'
--- a/sql/handler.h	2010-11-18 16:34:56 +0000
+++ b/sql/handler.h	2011-01-05 11:40:01 +0000
@@ -1556,6 +1556,7 @@ public:
     DBUG_ENTER("ha_rnd_init");
     DBUG_ASSERT(inited==NONE || (inited==RND && scan));
     inited= (result= rnd_init(scan)) ? NONE: RND;
+    end_range= NULL;
     DBUG_RETURN(result);
   }
   int ha_rnd_end()
@@ -1563,6 +1564,7 @@ public:
     DBUG_ENTER("ha_rnd_end");
     DBUG_ASSERT(inited==RND);
     inited=NONE;
+    end_range= NULL;
     DBUG_RETURN(rnd_end());
   }
   int ha_rnd_next(uchar *buf);


Attachment: [text/bzr-bundle] bzr/jorgen.loland@oracle.com-20110105114001-2oyjg1jyne6j39gl.bundle
Thread
bzr commit into mysql-trunk-bugfixing branch (jorgen.loland:3475) Bug#58837Jorgen Loland5 Jan