From: Jon Olav Hauglid
Date: January 4 2011 1:36pm
Subject: bzr commit into mysql-5.1 branch (jon.hauglid:3532) Bug#50619
List-Archive: http://lists.mysql.com/commits/127874
X-Bug: 50619
Message-Id: <201101041339.p04Ddk1e028048@rcsinet15.oracle.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8751604966706083354=="

--===============8751604966706083354==
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

#At file:///export/home/x/mysql-5.1-bug50619/ based on revid:guilhem.bichot@stripped

 3532 Jon Olav Hauglid	2011-01-04
      Bug #50619 assert in handler::update_auto_increment
      
      This assert could be triggered if -1 was inserted into
      an auto increment column by a statement writing more than
      one row.
      
      Unless explicitly given, an interval of auto increment values
      is generated when a statement first needs an auto increment
      value. The triggered assert checks that the auto increment
      counter is equal to or higher than the lower bound of this
      interval.
      
      Generally, the auto increment counter starts at 1 and is
      incremented by 1 each time it is used. However, inserting an
      explicit value into the auto increment column, sets the auto
      increment counter to this value + 1 if this value is higher
      than the current value of the auto increment counter.
      
      This bug was triggered if the explicit value was -1. Since the
      value was converted to unsigned before any comparisons were made,
      it was found to be higher than the current vale of the auto
      increment counter and the counter was set to -1 + 1. This value
      was below the reserved interval and caused the assert to be
      triggered the next time the statement tried to write a row.
      
      With the patch for Bug#39828, this bug is no longer repeatable.
      Now, -1 + 1 is detected as an "overflow" which causes the auto
      increment counter to be set to ULONGLONG_MAX. This avoids hitting
      the assert for the next insert and causes a new interval of
      auto increment values to be generated. This resolves the issue.
      
      This patch therefore only contains a regression test and no code
      changes. Test case added to auto_increment.test.

    modified:
      mysql-test/r/auto_increment.result
      mysql-test/t/auto_increment.test
=== modified file 'mysql-test/r/auto_increment.result'
--- a/mysql-test/r/auto_increment.result	2010-12-13 11:48:12 +0000
+++ b/mysql-test/r/auto_increment.result	2011-01-04 13:36:37 +0000
@@ -497,3 +497,22 @@ SET @@SESSION.AUTO_INCREMENT_INCREMENT=d
 SET @@SESSION.AUTO_INCREMENT_OFFSET=default;
 DROP TABLE t1;
 End of 5.1 tests
+#
+# Bug#50619 assert in handler::update_auto_increment
+#
+CREATE TABLE t1 (pk INT AUTO_INCREMENT, PRIMARY KEY (pk));
+INSERT INTO t1 VALUES (NULL), (-1), (NULL);
+SELECT * FROM t1;
+pk
+-1
+1
+2
+DROP TABLE t1;
+CREATE TABLE t1 (pk BIGINT UNSIGNED AUTO_INCREMENT, PRIMARY KEY (pk));
+INSERT INTO t1 VALUES (NULL), (18446744073709551615-1), (NULL);
+ERROR HY000: Failed to read auto-increment value from storage engine
+SELECT * FROM t1;
+pk
+1
+18446744073709551614
+DROP TABLE t1;

=== modified file 'mysql-test/t/auto_increment.test'
--- a/mysql-test/t/auto_increment.test	2010-12-13 11:48:12 +0000
+++ b/mysql-test/t/auto_increment.test	2011-01-04 13:36:37 +0000
@@ -363,3 +363,20 @@ SET @@SESSION.AUTO_INCREMENT_OFFSET=defa
 DROP TABLE t1;
 
 --echo End of 5.1 tests
+
+--echo #
+--echo # Bug#50619 assert in handler::update_auto_increment
+--echo #
+
+CREATE TABLE t1 (pk INT AUTO_INCREMENT, PRIMARY KEY (pk));
+# This triggered the assert
+INSERT INTO t1 VALUES (NULL), (-1), (NULL);
+SELECT * FROM t1;
+DROP TABLE t1;
+
+# Check that that true overflow still gives error
+CREATE TABLE t1 (pk BIGINT UNSIGNED AUTO_INCREMENT, PRIMARY KEY (pk));
+--error ER_AUTOINC_READ_FAILED
+INSERT INTO t1 VALUES (NULL), (18446744073709551615-1), (NULL);
+SELECT * FROM t1;
+DROP TABLE t1;


--===============8751604966706083354==
MIME-Version: 1.0
Content-Type: text/bzr-bundle; charset="us-ascii";
	name="bzr/jon.hauglid@stripped"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: jon.hauglid@stripped
# target_branch: file:///export/home/x/mysql-5.1-bug50619/
# testament_sha1: f29578ba7f70adf060387de834a27f02b4c9b84d
# timestamp: 2011-01-04 14:36:42 +0100
# base_revision_id: guilhem.bichot@stripped\
#   mf0jvafrh6kbwdek
# 
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWaJbbFwAA3dfgAAQWH///3//
3+C////wYAjyvvWzbM22qLddy3VsSlFrRKhKuEkpkp6ZIeo0GRkyHlHpNNMRoY1NAaADQSiNJpPR
oTampkyQ9E2oaGg0ANBiNNNAOGmmRiMJpgIYBNMIwTEyGmRoaASIggo9E9JoCam1MzU0JkADQGjQ
GgOGmmRiMJpgIYBNMIwTEyGmRoaASREMgTQAT0JhCanqaMnpDQaGgDTTTToUhb2KGemxPvWaezfN
crJze57+k3xGKV9lTRdeuCtJxx4uT6QQx+rkHxchV17S7KD6STRkrLwVZriVOi8vWq1PjDtBgroz
hlCo4fFty8B5E4ww2toUr5IP6dOeQFooq9WHAq8JvbUXcHJz/viiZg1hTfCHMHzBwTbskaA3GNex
+ES3+uyTaatbNU/VM7BYMuNF9DA49TIthB+8WZoWhGLZGcQNsmz32rVuOPJUpnGZW01YA0b4/Gbz
aU4YTcrYhyI/zElbcQINJpyHpjGDNBHM904M9Z/rUHSCh0BnsCvMUtwa8yYbDBoZEWjGm/blF8MY
nJXeUY6xDKYlSMIhjGwkfLblrfZhf04W9ND6PDvuX26/UijR8zB+psbNsMaEefoD3hWH1DsMqEtU
ALOYdmxuVlyJr1exmfE1nNC0APyDH2BmIzXg9QetNpw40muneFlG7a3WzX92mhIiLjNUGaW8iaFi
gsG2YvUI+LNEvyQigDA8hBQGHWEwZNIpiEZTC5liYFUytAqv5mLG5bDdiYBnCA44MD04OHk0e7LY
Baj1d44FKy0LgbvOkCK1qy9ximrXMpkkSkWw0Rrvk5qA9IU5Q50rIduFRK0KjBJ03tW4hybqrEvp
a/CZsAxHmXKcpc6YDDkZznWENCZxJiu0yhzTpyJbnxT0BwKqlQUujH4VcZFEEwxaeZADIBQombIB
sniQAqTAg85pGkUrblkBcSlFkrRwZAUoxYVoSVSsoV2Yh8gLJFSx7DmTibdq575kNDm4wMjTNJuw
NSasb0xrx1I94bNeRxIMf6eehs8BC7+myK5TM5qmkw3nd5FoTA0FMt0btdHXwLqlksH1YBZstmqS
J3ESJXebr3VQEHKYIwKBWxV5eXHeVmiRVmtkq8oOduasptN3UoAyAbTkSlvpgxpilmUDK11NxCpd
OmnONaYuKQKy26KlVqpaUB2RBUi9xWV5SfYVmcwO8DGloXMsrS9OLGqi5EKbSDtBFVgit3yK6wjJ
hMUKa3XHjF43UWPAv2SooUGIDs0fgZAcH+7AnTaNNuT3AW3SqB7woDmFIVzD7APwRN0SPeEQsCUA
r+IfEL4I/0mw1UF3ki+wJB9ohE7RQxULwJAYhO9AjaEgYLKgchAYcFQoMCh8gLaIXBaKg4J5gUFs
7QOoNYfwErkYAyLQ0CsmDlIMKAFIOGCIFmxrQKAQqopAOMAuHveWga8XQu3xEH6iGRBlyQIlRAKd
PoKCmLojzYRKo6rdguqGFkWo3rSx8tYSNSvtM9WeJwrwiAfsPu2gYe6rF9sAavBRWiMKqkahuRIK
ZFII12oXoYxh2ZsFnPiycJTTMdx3vcsF7m/JcHs4jmV05oR31l9c/yPEgXEw6+Hh2k4wut3KRViH
AlK1EtYRZouki1pLyT1QVGhpjY2HGMvySX2FgqDkS7lj6H38FHH06F115LZmZznv8u837uFEL2vQ
tcZPmdmVpLkytFO+80sZuTMAbuPC3b3+JGPGPkXmrRWndWkkbs+bbzTlRHU7mrLCGttVsdrUNfx4
2dNbcMbijuvXWztar4OPoUwWQZMwEbvX0nT1iVm2m0mOqhE2v3O7kas9OyOlarCSJSOe1WYuIjve
wGpaLM8schdg8vawoQUzK1pkijDHAcmi4r63smZtvAIp+uk5c12jgZ6XXT0AZr3mpqtxw5ZO0Z4P
wTinY22HmdTBosV6EOhxAPEpEeJ20b7bV4m9lxP1LlgRiKgLlB1agYSOU/XR0XTOqthCtQmMyGHq
FaYmfYikzZUHFvBZFsbV9CHQd0KZ5FcoIrWviLHFSRIPdcnDKzDWsSlO5HRF1jYUs+/t8VNBaW2I
ZRkJtc6OSToKu0s6iKU9SqWLbiY0GNMbNa5dV8UowNeLQdK1FggO08aLX1XZuasboyCqK/DIfXfe
ekw4ZiUowXCFqtoiqHCuHHlezxymFKRM7z5xu6d71U0CViazmrywoELsk615MNpjhN166lCbmhKx
vlJlRRRqlJEsitWkhhi3CITpxVi6hUCa0x/GnUXLy1jcSUuEpFCbBqcOw8N24O9NLawG0B1cvGjz
SbIuAfK89qBg7Om6uciavaL/ISuE5tZcILKtPCvtqdKgr9F6/O8f778BSJdrDBFzenW/DSekDzWm
qbew7Tn7gOo2bV3bKmyGMbwYQw9DMgGeA1QEN2MOzGhxNuSRsJpQVnsWbVFSRirgHvzir8zRTevN
oZHMZHa0LPLKUQuBy2KWffHopg5Y2V6JkrEJ+atmTRF8Keot4+GfJbLYc6rm0mVoci5j0XW8vhtR
J6uw2nKzeaX4HxtvmVDUB1Z0tLUW1GyVG1VZcio5GxMPLhSpNytqMs2xvhdazDSrAPKrFRKLAaMH
Q5OLqznTaRQ6WZgs5BeODVucmEzAKq6d0TAsjKlrNyqSYBh2TpEhSuOiM5jDRyGB5+fYKrMn3M9n
UNPUR3qhY5O6IG0iYMlpVEs41DIF6zgaCRzWUKgNQxcQ06lhgRNTwqji4ewCcBZZtG9TDYY+XgXE
WOOujGwryBsOMmQGTA4QHGD0lLcWf8XckU4UJCiW2xcA


--===============8751604966706083354==--