List:Commits« Previous MessageNext Message »
From:Libing Song Date:December 28 2010 8:33am
Subject:Re: bzr commit into mysql-trunk-bugfixing branch (Li-Bing.Song:3426)
Bug#55798 Bug#56184
View as plain text  
On Tue, 2010-12-28 at 06:30 +0000, Alfranio Correia wrote:
> Hi Libing,
> 
> On 12/28/2010 03:30 AM, Libing Song wrote:
> > Hi Alfranio,
> > Thanks for your review.
> > Please find my comments below.
> > 
> > On Mon, 2010-12-27 at 10:48 +0000, Alfranio Correia wrote:
> >> Hi Libing,
> >>
> >>
> >> 9. In the cases below, you are not taking into account if the "creation"
> >> did not fail:
> >>
> > Could you please explain it?
> > I just saw another problem that it should not be taken into account if
> > the "creation' fails.
> >>    /*
> >>      CREATE TEMPORARY TABLE doesn't terminate a transaction. Calling
> >>      stmt.created_temp_table() guarantees the transaction can be
> >>      binlogged correctly.
> >>    */
> >>    if (create_info->options & HA_LEX_CREATE_TMP_TABLE)
> >>      thd->transaction.stmt.created_temp_table();
> 
> I think you should do:
> 
>     if (!res && create_info->options & HA_LEX_CREATE_TMP_TABLE)
>       thd->transaction.stmt.created_temp_table();
Got it, thanks!
> 
> Cheers.
> 

-- 
Your Sincerely,
Libing Song
==================================
MySQL Replication Team
Software Engineer


Email : Li-Bing.Song@stripped
Skype : libing.song
MSN   : slb_database@stripped
Phone : +86 010-6505-4020 ext. 319
Mobile: +86 138-1144-2038
==================================

Thread
bzr commit into mysql-trunk-bugfixing branch (Li-Bing.Song:3426) Bug#55798Bug#56184Li-Bing.Song13 Dec
  • Re: bzr commit into mysql-trunk-bugfixing branch (Li-Bing.Song:3426)Bug#55798 Bug#56184Daogang Qu13 Dec
    • Re: bzr commit into mysql-trunk-bugfixing branch (Li-Bing.Song:3426)Bug#55798 Bug#56184Libing Song16 Dec
  • Re: bzr commit into mysql-trunk-bugfixing branch (Li-Bing.Song:3426)Bug#55798 Bug#56184Alfranio Correia27 Dec
    • Re: bzr commit into mysql-trunk-bugfixing branch (Li-Bing.Song:3426)Bug#55798 Bug#56184Libing Song28 Dec
      • Re: bzr commit into mysql-trunk-bugfixing branch (Li-Bing.Song:3426)Bug#55798 Bug#56184Alfranio Correia28 Dec
        • Re: bzr commit into mysql-trunk-bugfixing branch (Li-Bing.Song:3426)Bug#55798 Bug#56184Libing Song28 Dec