#At file:///Users/kevinlewis/Work/Mysql/Bug43818/mysql-5.1-innodb/ based on revid:marko.makela@stripped
3671 kevin.lewis@stripped 2010-12-23
Bug#43818 - Patch for mysql-5.1-innodb
Avoid handler::info() call for three Information Schema tables;
TABLE_CONSTRAINTS, KEY_COLUMN_USAGE, & REFERENTIAL_CONTRAINTS
modified:
sql/sql_show.cc
=== modified file 'sql/sql_show.cc'
--- a/sql/sql_show.cc revid:marko.makela@stripped
+++ b/sql/sql_show.cc revid:kevin.lewis@stripped
@@ -4647,9 +4647,10 @@ static int get_schema_constraints_record
TABLE *show_table= tables->table;
KEY *key_info=show_table->key_info;
uint primary_key= show_table->s->primary_key;
- show_table->file->info(HA_STATUS_VARIABLE |
- HA_STATUS_NO_LOCK |
- HA_STATUS_TIME);
+
+ // This is not needed since no statistics are displayed.
+ // show_table->file->info(HA_STATUS_VARIABLE | HA_STATUS_NO_LOCK | HA_STATUS_TIME);
+
for (uint i=0 ; i < show_table->s->keys ; i++, key_info++)
{
if (i != primary_key && !(key_info->flags & HA_NOSAME))
@@ -4831,9 +4832,10 @@ static int get_schema_key_column_usage_r
TABLE *show_table= tables->table;
KEY *key_info=show_table->key_info;
uint primary_key= show_table->s->primary_key;
- show_table->file->info(HA_STATUS_VARIABLE |
- HA_STATUS_NO_LOCK |
- HA_STATUS_TIME);
+
+ // This is not needed since no statistics are displayed.
+ // show_table->file->info(HA_STATUS_VARIABLE | HA_STATUS_NO_LOCK | HA_STATUS_TIME);
+
for (uint i=0 ; i < show_table->s->keys ; i++, key_info++)
{
if (i != primary_key && !(key_info->flags & HA_NOSAME))
@@ -5562,9 +5564,9 @@ get_referential_constraints_record(THD *
{
List<FOREIGN_KEY_INFO> f_key_list;
TABLE *show_table= tables->table;
- show_table->file->info(HA_STATUS_VARIABLE |
- HA_STATUS_NO_LOCK |
- HA_STATUS_TIME);
+
+ // This is not needed since no statistics are displayed.
+ // show_table->file->info(HA_STATUS_VARIABLE | HA_STATUS_NO_LOCK | HA_STATUS_TIME);
show_table->file->get_foreign_key_list(thd, &f_key_list);
FOREIGN_KEY_INFO *f_key_info;
Attachment: [text/bzr-bundle] bzr/kevin.lewis@oracle.com-20101223224959-z3lk2qkqa41xg2uw.bundle
| Thread |
|---|
| • bzr commit into mysql-5.1-innodb branch (kevin.lewis:3671) Bug#43818 | kevin.lewis | 23 Dec |