List:Commits« Previous MessageNext Message »
From:Alexander Nozdrin Date:December 22 2010 1:25pm
Subject:bzr push into mysql-trunk-bugfixing branch (alexander.nozdrin:3468 to 3469)
Bug#59022
View as plain text  
 3469 Alexander Nozdrin	2010-12-22
      A patch for Bug#59022 (Valgrind warning in write_delayed() after InnoDB merge).
      
      Fix memory leak introduced by WL#5092 'RBR: Options for writing
      partial or full row images in RBR events'.
      
      Free memory which is allocated for column bitmap associated with
      each row to be processed by delayed insert handler thread.

    modified:
      sql/sql_insert.cc
 3468 He Zhenxing	2010-12-22 [merge]
      Auto merge

    modified:
      sql/mysqld.cc
=== modified file 'sql/sql_insert.cc'
--- a/sql/sql_insert.cc	2010-11-29 16:27:58 +0000
+++ b/sql/sql_insert.cc	2010-12-22 13:23:59 +0000
@@ -1843,11 +1843,14 @@ public:
     : record(0), dup(dup_arg), ignore(ignore_arg), log_query(log_query_arg),
       binlog_rows_query_log_events(FALSE),
       forced_insert_id(0), query(query_arg), time_zone(0)
-    {}
+    {
+      write_set.bitmap= NULL;
+    }
   ~delayed_row()
   {
     my_free(query.str);
     my_free(record);
+    my_free(write_set.bitmap);
   }
 };
 

No bundle (reason: useless for push emails).
Thread
bzr push into mysql-trunk-bugfixing branch (alexander.nozdrin:3468 to 3469)Bug#59022Alexander Nozdrin22 Dec