List:Commits« Previous MessageNext Message »
From:Alexander Nozdrin Date:December 22 2010 1:22pm
Subject:bzr commit into mysql-trunk-bugfixing branch (alexander.nozdrin:3465)
Bug#59022
View as plain text  
#At file:///home/alik/MySQL/bzr/00.build/mysql-trunk-bugfixing/ based on revid:tor.didriksen@stripped

 3465 Alexander Nozdrin	2010-12-22
      A patch for Bug#59022 (Valgrind warning in write_delayed() after InnoDB merge).
      
      Fix memory leak introduced by WL#5092 'RBR: Options for writing
      partial or full row images in RBR events'.
      
      Free memory which is allocated for column bitmap associated with
      each row to be processed by delayed insert handler thread.

    modified:
      sql/sql_insert.cc
=== modified file 'sql/sql_insert.cc'
--- a/sql/sql_insert.cc	2010-11-29 16:27:58 +0000
+++ b/sql/sql_insert.cc	2010-12-22 13:22:57 +0000
@@ -1843,11 +1843,14 @@ public:
     : record(0), dup(dup_arg), ignore(ignore_arg), log_query(log_query_arg),
       binlog_rows_query_log_events(FALSE),
       forced_insert_id(0), query(query_arg), time_zone(0)
-    {}
+    {
+      write_set.bitmap= NULL;
+    }
   ~delayed_row()
   {
     my_free(query.str);
     my_free(record);
+    my_free(write_set.bitmap);
   }
 };
 


Attachment: [text/bzr-bundle] bzr/alexander.nozdrin@oracle.com-20101222132257-0jya313x7yk4i2b7.bundle
Thread
bzr commit into mysql-trunk-bugfixing branch (alexander.nozdrin:3465)Bug#59022Alexander Nozdrin22 Dec