List:Commits« Previous MessageNext Message »
From:Libing Song Date:December 22 2010 6:55am
Subject:Re: bzr commit into mysql-trunk-bugfixing branch (zhenxing.he:3447)
Bug#59079
View as plain text  
Hi Zhenxing,
Nice work, please find my comments below.

STATUS
------
 
  Not Approved.

REQUIRED CHANGES
----------------
No

REQUESTS
--------
Do you think 'show binlog events .. limit 4,1' is a better way to show
the incident event? The example patch by using limit is like:

 -- echo ### check that the incident event is written to the current log
 SET GLOBAL debug="-d,error_unique_log_filename";
--- let $binlog_start= query_get_value(SHOW MASTER STATUS, Position, 1)
--- let $binlog_file= query_get_value(SHOW MASTER STATUS, File, 1)
 
-# 53 is the size of the incident event, so we start from 22 bytes
before the
-# current position
--- let $binlog_start = `SELECT $binlog_start - 53`
-FLUSH LOGS;
--- replace_result $MYSQLTEST_VARDIR MYSQLTEST_VARDIR $binlog_start
<binlog_start> $binl
og_file
BINLOG_FILE                                                                    
--- replace_column 2 # 4 # 5 #
--- eval SHOW BINLOG EVENTS IN '$binlog_file' FROM $binlog_start LIMIT 1
+-- let $binlog_limit= 4,1
+-- source include/show_binlog_events.inc
 


SUGGESTIONS
-----------
NO

DETAILS 
-------
NO


-- 
Your Sincerely,
Libing Song
==================================
MySQL Replication Team
Software Engineer


Email : Li-Bing.Song@stripped
Skype : libing.song
MSN   : slb_database@stripped
Phone : +86 010-6505-4020 ext. 319
Mobile: +86 138-1144-2038
==================================

Thread
bzr commit into mysql-trunk-bugfixing branch (zhenxing.he:3447) Bug#59079He Zhenxing21 Dec
  • Re: bzr commit into mysql-trunk-bugfixing branch (zhenxing.he:3447)Bug#59079Libing Song22 Dec
    • Re: bzr commit into mysql-trunk-bugfixing branch (zhenxing.he:3447)Bug#59079He Zhenxing22 Dec
  • Re: bzr commit into mysql-trunk-bugfixing branch (zhenxing.he:3447)Bug#59079Libing Song22 Dec