List:Commits« Previous MessageNext Message »
From:ingo Date:September 28 2006 11:41am
Subject:bk commit into 4.0 tree (istruewing:1.2196) BUG#22384
View as plain text  
Below is the list of changes that have just been committed into a local
4.0 repository of istruewing. When istruewing does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-09-28 11:41:38+02:00, istruewing@stripped +1 -0
  Bug#22384 - DELETE FROM table causes "Incorrect key file for table"
  
  Deletes on a big index could crash the index when it needs to
  shrink.
  
  Put a forgotten negation operator in.
  
  No test case. It is too big for the test suite. And it does not
  work with 4.0, only with higher versions. It is attached to the
  bug report.

  myisam/mi_delete.c@stripped, 2006-09-28 11:41:37+02:00, istruewing@stripped +1 -1
    Bug#22384 - DELETE FROM table causes "Incorrect key file for table"
    Put a negation operator ('!') before _mi_get_last_key() in del().
    It returns NULL on error, non-NULL on success.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	istruewing
# Host:	chilla.local
# Root:	/home/mydev/mysql-4.0-bug22384

--- 1.14/myisam/mi_delete.c	2006-09-28 11:41:39 +02:00
+++ 1.15/myisam/mi_delete.c	2006-09-28 11:41:39 +02:00
@@ -348,7 +348,7 @@ static int del(register MI_INFO *info, r
 	else
 	{
 	  DBUG_PRINT("test",("Inserting of key when deleting"));
-	  if (_mi_get_last_key(info,keyinfo,leaf_buff,keybuff,endpos,
+	  if (!_mi_get_last_key(info,keyinfo,leaf_buff,keybuff,endpos,
 				&tmp))
 	    goto err;
 	  ret_value=_mi_insert(info,keyinfo,key,leaf_buff,endpos,keybuff,
Thread
bk commit into 4.0 tree (istruewing:1.2196) BUG#22384ingo28 Sep