List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:December 14 2010 4:26pm
Subject:Re: bzr commit into mysql-5.1-innodb branch (vasil.dimov:3666) Bug#51023
View as plain text  
On 12/14/10 2:12 PM, Vasil Dimov wrote:
>> >  Hum, I think we can simplify this function a bit in order to make this
>> >  pointer to pointer passing nicer and reduce the amount of duplicated code:
>> >
>> >  - Rename reopen_fstreams to repoen_fstream and make it take only a
>> >  single FILE stream.
>> >
>> >  - Make reopen_fstream and my_freopen return a FILE stream, much like
>> >  freopen.
>> >
>> >  - Add a my_reopen_stream wrapper that takes a FILE **. It passes the
>> >  stream pointer (FILE *) to reopen_fstream, takes the returned pointer
>> >  and sets it if on FreeBSD.
> Lets do this simplification as a separate commit from the actual bugfix.
>

I don't see a point in delaying a better patch if we could have it now. 
The next 5.1 release is weeks away. If you do not want to implement it, 
just say so and I'll take care of it.

Regards,

Davi
Thread
bzr commit into mysql-5.1-innodb branch (vasil.dimov:3666) Bug#51023vasil.dimov8 Dec
  • Re: bzr commit into mysql-5.1-innodb branch (vasil.dimov:3666) Bug#51023Davi Arnaut13 Dec
    • Re: bzr commit into mysql-5.1-innodb branch (vasil.dimov:3666)Bug#51023Vasil Dimov14 Dec
      • Re: bzr commit into mysql-5.1-innodb branch (vasil.dimov:3666) Bug#51023Davi Arnaut14 Dec
        • Re: bzr commit into mysql-5.1-innodb branch (vasil.dimov:3666)Bug#51023Vasil Dimov15 Dec
  • Re: bzr commit into mysql-5.1-innodb branch (vasil.dimov:3666) Bug#51023Davi Arnaut13 Dec