On 12/14/10 2:12 PM, Vasil Dimov wrote:
>> > Hum, I think we can simplify this function a bit in order to make this
>> > pointer to pointer passing nicer and reduce the amount of duplicated code:
>> >
>> > - Rename reopen_fstreams to repoen_fstream and make it take only a
>> > single FILE stream.
>> >
>> > - Make reopen_fstream and my_freopen return a FILE stream, much like
>> > freopen.
>> >
>> > - Add a my_reopen_stream wrapper that takes a FILE **. It passes the
>> > stream pointer (FILE *) to reopen_fstream, takes the returned pointer
>> > and sets it if on FreeBSD.
> Lets do this simplification as a separate commit from the actual bugfix.
>
I don't see a point in delaying a better patch if we could have it now.
The next 5.1 release is weeks away. If you do not want to implement it,
just say so and I'll take care of it.
Regards,
Davi
