From: Martin Hansson Date: December 14 2010 12:56pm Subject: Re: bzr commit into mysql-trunk-bugfixing branch (martin.hansson:3255) List-Archive: http://lists.mysql.com/commits/126766 Message-Id: <4D07696E.2050007@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Tor Didriksen skrev 2010-12-13 14.42: > Hi Martin > > Nice patch. > > - please use the term 'member function' rather than 'method'. Done. > - please mention somewhere that all the clone() implementations rely on the > compiler-generated Copy Constructor, which does memberwise initialization. I mention that they call the copy constructor. As for what the copy constructor does, it might change so I dare not speak of it. > - please give per-file comments. Done. > - please write a bug, for easier tracking when merging between trees You've got mail. ;-) Best Regards Martin