List:Commits« Previous MessageNext Message »
From:Martin Hansson Date:December 14 2010 12:56pm
Subject:Re: bzr commit into mysql-trunk-bugfixing branch (martin.hansson:3255)
View as plain text  
Tor Didriksen skrev 2010-12-13 14.42:
> Hi Martin
>
> Nice patch.
>
> - please use the term 'member function' rather than 'method'.
Done.
> - please mention somewhere that all the clone() implementations rely on the
>    compiler-generated Copy Constructor, which does memberwise initialization.
I mention that they call the copy constructor. As for what the copy 
constructor does, it might change so I dare not speak of it.
> - please give per-file comments.
Done.
> - please write a bug, for easier tracking when merging between trees
You've got mail. ;-)

Best Regards

Martin
Thread
bzr commit into mysql-trunk-bugfixing branch (martin.hansson:3255) Martin Hansson8 Dec
Re: bzr commit into mysql-trunk-bugfixing branch (martin.hansson:3255)Tor Didriksen13 Dec
  • Re: bzr commit into mysql-trunk-bugfixing branch (martin.hansson:3255)Martin Hansson14 Dec
    • Re: bzr commit into mysql-trunk-bugfixing branch (martin.hansson:3255)Tor Didriksen15 Dec
      • Re: bzr commit into mysql-trunk-bugfixing branch (martin.hansson:3255)Martin Hansson15 Dec