Hi Luis,
Nice work!
Please find my review comments below.
STATUS
------
Not Approved.
REQUIRED CHANGES
----------------
RE1. I think it is better to report a separated error which different
from the original one. The original report ("...retries: %d") is just
for a connecting error. When reporting a fatal error, "... retries: %d"
is not need. Also the original report doesn't print the error's detail
message. it reports only the error number. I suppose the connect error
message has been print before connect_to_master() handles it. But 'user
denied' error message never appears in error log file. So I think the
error message should be print here like this:
+ if (!is_network_error(last_errno))
+ {
+ slave_was_killed= 1;
+ mi->report(ERROR_LEVEL, last_errno, "error %s to master '%s@%s:%
d, %s",
+ reconnect ? "reconnect" : "connection", mi->user,
mi->host,
+ mi->port, mysql_error(mysql));
+ break;
+ }
REQUESTS
--------
NO
SUGGESTIONS
-----------
NO
DETAILS
-------
NO
--
Your Sincerely,
Libing Song
==================================
MySQL Replication Team
Software Engineer
Email : Li-Bing.Song@stripped
Skype : libing.song
MSN : slb_database@stripped
Phone : +86 010-6505-4020 ext. 319
Mobile: +86 138-1144-2038
==================================
