List:Commits« Previous MessageNext Message »
From:Libing Song Date:December 10 2010 9:12am
Subject:Re: bzr commit into mysql-5.1-bugteam branch (Dao-Gang.Qu:3521)
Bug#50914
View as plain text  
Hi Daogang,
Nice work.

Please find my review comments below.

STATUS
------
 
  Not Approved.

REQUIRED CHANGES
----------------
RC1. It is better to move the test into mysqlbinlog.test, as
it is a bug of mysqlbinlog.

RC2. 
BEGIN, COMMIT, ROLLBACK and SAVEPOINT suppress the USE too.
Could you please use blow code to confine the effect range of your code?
+ if ((flags & LOG_EVENT_SUPPRESS_F) && !is_trans_keyword())
+   print_event_info->db[0]= '\0';

The patch will not affect other tests in mysqlbinlog.test if you use
above code in the patch.

REQUESTS
--------
RE1. Could you explain why you add the code below in database.test?
--- 
@@ -12,6 +12,7 @@ create function sf1 (a int) returns int
 create trigger tr1 before insert on t1 for each row insert into t2
values (2*new.a);
 create procedure sp1 (a int) insert into t1 values(a);
 drop database testing_1;
+let $binlog_file= query_get_value(SHOW MASTER STATUS, File, 1);
 source include/show_binlog_events.inc;
 
 # BUG#38773: DROP DATABASE cause switch to stmt-mode when there are
@@ -27,6 +28,34 @@ drop database if exists mysqltest1;
 enable_warnings;
 insert into t1 values (1);
 drop table tt1, t1;
+let $binlog_file= query_get_value(SHOW MASTER STATUS, File, 1);

RE2. Could you explain why it is need to show binlog events?

+let $MYSQLD_DATADIR= `select @@datadir`;
+exec $MYSQL_BINLOG $MYSQLD_DATADIR/$master_binlog | $MYSQL test 2>&1;
+
+let $binlog_file= query_get_value(SHOW MASTER STATUS, File, 1);

I think it can be removed, as the code
exec $MYSQL_BINLOG $MYSQLD_DATADIR/$master_binlog | $MYSQL test 2>&1;
will fail if it is not fixed.

SUGGESTIONS
-----------
SU1.
RESET master.
select @@datadir

It is better to use uppercase for 'master' and 'select'.




DETAILS 
-------
n/a
On Tue, 2010-12-07 at 06:58 +0000, Dao-Gang.Qu@stripped wrote:
> #At file:///home/daogang/bzrwork/bug50914/mysql-5.1-bugteam/ based on
> revid:azundris@stripped
> 
>  3521 Dao-Gang.Qu@stripped	2010-12-07
>       Bug #50914  	mysqlbinlog not handling drop of current default database
>       
>       mysqlbinlog only prints "use $database" statements to its output stream
>       when the active default database changes between events. Which will cause
>       "No Database Selected" error when dropping and recreating that database
>       though.
>       
>       To fix the problem to clear print_event_info->db when printing an event
>       with LOG_EVENT_SUPPRESS_USE flag, which will be set for CREATE/DROP/ALTER
>       database statements, so that the Query_log_event after such statements
>       will be printed with the use 'db' anyway.
>      @ mysql-test/extra/binlog_tests/database.test
>         Added test to verify if the approach of the mysqlbinlog prints
>         "use $database"statements to its output stream will cause
>         "No Database Selected" error when dropping and recreating
>         that database though.
>      @ mysql-test/r/mysqlbinlog.result
>         Updated for the patch of Bug#50914.
>      @ mysql-test/suite/binlog/r/binlog_database.result
>         Test result for Bug#50914.
>      @ sql/log_event.cc
>         Updated code to make mysqlbinlog print "use $database" statements
>         to its output stream for every query log event as long as the
>         database is not suppressed expressly.
> 
>     modified:
>       mysql-test/extra/binlog_tests/database.test
>       mysql-test/r/mysqlbinlog.result
>       mysql-test/suite/binlog/r/binlog_database.result
>       sql/log_event.cc
> === modified file 'mysql-test/extra/binlog_tests/database.test'
> --- a/mysql-test/extra/binlog_tests/database.test	2009-01-23 12:22:05 +0000
> +++ b/mysql-test/extra/binlog_tests/database.test	2010-12-07 06:58:31 +0000
> @@ -12,6 +12,7 @@ create function sf1 (a int) returns int
>  create trigger tr1 before insert on t1 for each row insert into t2 values
> (2*new.a);
>  create procedure sp1 (a int) insert into t1 values(a);
>  drop database testing_1;
> +let $binlog_file= query_get_value(SHOW MASTER STATUS, File, 1);
>  source include/show_binlog_events.inc;
>  
>  # BUG#38773: DROP DATABASE cause switch to stmt-mode when there are
> @@ -27,6 +28,34 @@ drop database if exists mysqltest1;
>  enable_warnings;
>  insert into t1 values (1);
>  drop table tt1, t1;
> +let $binlog_file= query_get_value(SHOW MASTER STATUS, File, 1);
> +source include/show_binlog_events.inc;
> +
> +#
> +# BUG#50914
> +# This test verifies if the approach of the mysqlbinlog prints
> +# "use $database"statements to its output stream will cause
> +# "No Database Selected" error when dropping and recreating
> +# that database though.
> +#
> +RESET master;
> +CREATE DATABASE test1;
> +USE test1;
> +CREATE TABLE t1(id int);
> +DROP DATABASE test1;
> +CREATE DATABASE test1;
> +USE test1;
> +CREATE TABLE t1(id int);
> +DROP TABLE t1;
> +DROP DATABASE test1;
> +let $master_binlog= query_get_value(SHOW MASTER STATUS, File, 1);
> +FLUSH LOGS;
> +
> +let $MYSQLD_DATADIR= `select @@datadir`;
> +exec $MYSQL_BINLOG $MYSQLD_DATADIR/$master_binlog | $MYSQL test 2>&1;
> +
> +let $binlog_file= query_get_value(SHOW MASTER STATUS, File, 1);
>  source include/show_binlog_events.inc;
>  
>  FLUSH STATUS;
> +
> 
> === modified file 'mysql-test/r/mysqlbinlog.result'
> --- a/mysql-test/r/mysqlbinlog.result	2010-03-28 11:57:33 +0000
> +++ b/mysql-test/r/mysqlbinlog.result	2010-12-07 06:58:31 +0000
> @@ -499,6 +499,7 @@ create table t1(a int) engine= innodb
>  SET TIMESTAMP=1253783037/*!*/;
>  BEGIN
>  /*!*/;
> +use test/*!*/;
>  SET TIMESTAMP=1253783037/*!*/;
>  insert into t1 (a) values (1)
>  /*!*/;
> @@ -509,18 +510,21 @@ create table t3(a int) engine= innodb
>  SET TIMESTAMP=1253783037/*!*/;
>  BEGIN
>  /*!*/;
> +use test/*!*/;
>  SET TIMESTAMP=1253783037/*!*/;
>  insert into t3 (a) values (2)
>  /*!*/;
>  SET TIMESTAMP=1253783037/*!*/;
>  ROLLBACK
>  /*!*/;
> +use test/*!*/;
>  SET TIMESTAMP=1253783037/*!*/;
>  create table t5(a int) engine= NDB
>  /*!*/;
>  SET TIMESTAMP=1253783037/*!*/;
>  BEGIN
>  /*!*/;
> +use test/*!*/;
>  SET TIMESTAMP=1253783037/*!*/;
>  insert into t5 (a) values (3)
>  /*!*/;
> 
> === modified file 'mysql-test/suite/binlog/r/binlog_database.result'
> --- a/mysql-test/suite/binlog/r/binlog_database.result	2009-05-31 05:44:41 +0000
> +++ b/mysql-test/suite/binlog/r/binlog_database.result	2010-12-07 06:58:31 +0000
> @@ -7,7 +7,7 @@ create function sf1 (a int) returns int
>  create trigger tr1 before insert on t1 for each row insert into t2 values
> (2*new.a);
>  create procedure sp1 (a int) insert into t1 values(a);
>  drop database testing_1;
> -show binlog events from <binlog_start>;
> +show binlog events in 'master-bin.000001' from <binlog_start>;
>  Log_name	Pos	Event_type	Server_id	End_log_pos	Info
>  master-bin.000001	#	Query	#	#	create database testing_1
>  master-bin.000001	#	Query	#	#	use `testing_1`; create table t1 (a int)
> @@ -25,7 +25,7 @@ insert into t1 values (1);
>  drop database if exists mysqltest1;
>  insert into t1 values (1);
>  drop table tt1, t1;
> -show binlog events from <binlog_start>;
> +show binlog events in 'master-bin.000001' from <binlog_start>;
>  Log_name	Pos	Event_type	Server_id	End_log_pos	Info
>  master-bin.000001	#	Query	#	#	use `test`; create temporary table tt1 (a int)
>  master-bin.000001	#	Query	#	#	use `test`; create table t1 (a int)
> @@ -33,6 +33,26 @@ master-bin.000001	#	Query	#	#	use `test`
>  master-bin.000001	#	Query	#	#	drop database if exists mysqltest1
>  master-bin.000001	#	Query	#	#	use `test`; insert into t1 values (1)
>  master-bin.000001	#	Query	#	#	use `test`; drop table tt1, t1
> +RESET master;
> +CREATE DATABASE test1;
> +USE test1;
> +CREATE TABLE t1(id int);
> +DROP DATABASE test1;
> +CREATE DATABASE test1;
> +USE test1;
> +CREATE TABLE t1(id int);
> +DROP TABLE t1;
> +DROP DATABASE test1;
> +FLUSH LOGS;
> +show binlog events in 'master-bin.000002' from <binlog_start>;
> +Log_name	Pos	Event_type	Server_id	End_log_pos	Info
> +master-bin.000002	#	Query	#	#	CREATE DATABASE test1
> +master-bin.000002	#	Query	#	#	use `test1`; CREATE TABLE t1(id int)
> +master-bin.000002	#	Query	#	#	DROP DATABASE test1
> +master-bin.000002	#	Query	#	#	CREATE DATABASE test1
> +master-bin.000002	#	Query	#	#	use `test1`; CREATE TABLE t1(id int)
> +master-bin.000002	#	Query	#	#	use `test1`; DROP TABLE t1
> +master-bin.000002	#	Query	#	#	DROP DATABASE test1
>  FLUSH STATUS;
>  set binlog_format=mixed;
>  reset master;
> @@ -43,7 +63,7 @@ create function sf1 (a int) returns int
>  create trigger tr1 before insert on t1 for each row insert into t2 values
> (2*new.a);
>  create procedure sp1 (a int) insert into t1 values(a);
>  drop database testing_1;
> -show binlog events from <binlog_start>;
> +show binlog events in 'master-bin.000001' from <binlog_start>;
>  Log_name	Pos	Event_type	Server_id	End_log_pos	Info
>  master-bin.000001	#	Query	#	#	create database testing_1
>  master-bin.000001	#	Query	#	#	use `testing_1`; create table t1 (a int)
> @@ -61,7 +81,7 @@ insert into t1 values (1);
>  drop database if exists mysqltest1;
>  insert into t1 values (1);
>  drop table tt1, t1;
> -show binlog events from <binlog_start>;
> +show binlog events in 'master-bin.000001' from <binlog_start>;
>  Log_name	Pos	Event_type	Server_id	End_log_pos	Info
>  master-bin.000001	#	Query	#	#	use `test`; create temporary table tt1 (a int)
>  master-bin.000001	#	Query	#	#	use `test`; create table t1 (a int)
> @@ -69,6 +89,26 @@ master-bin.000001	#	Query	#	#	use `test`
>  master-bin.000001	#	Query	#	#	drop database if exists mysqltest1
>  master-bin.000001	#	Query	#	#	use `test`; insert into t1 values (1)
>  master-bin.000001	#	Query	#	#	use `test`; drop table tt1, t1
> +RESET master;
> +CREATE DATABASE test1;
> +USE test1;
> +CREATE TABLE t1(id int);
> +DROP DATABASE test1;
> +CREATE DATABASE test1;
> +USE test1;
> +CREATE TABLE t1(id int);
> +DROP TABLE t1;
> +DROP DATABASE test1;
> +FLUSH LOGS;
> +show binlog events in 'master-bin.000002' from <binlog_start>;
> +Log_name	Pos	Event_type	Server_id	End_log_pos	Info
> +master-bin.000002	#	Query	#	#	CREATE DATABASE test1
> +master-bin.000002	#	Query	#	#	use `test1`; CREATE TABLE t1(id int)
> +master-bin.000002	#	Query	#	#	DROP DATABASE test1
> +master-bin.000002	#	Query	#	#	CREATE DATABASE test1
> +master-bin.000002	#	Query	#	#	use `test1`; CREATE TABLE t1(id int)
> +master-bin.000002	#	Query	#	#	use `test1`; DROP TABLE t1
> +master-bin.000002	#	Query	#	#	DROP DATABASE test1
>  FLUSH STATUS;
>  set binlog_format=row;
>  reset master;
> @@ -79,7 +119,7 @@ create function sf1 (a int) returns int
>  create trigger tr1 before insert on t1 for each row insert into t2 values
> (2*new.a);
>  create procedure sp1 (a int) insert into t1 values(a);
>  drop database testing_1;
> -show binlog events from <binlog_start>;
> +show binlog events in 'master-bin.000001' from <binlog_start>;
>  Log_name	Pos	Event_type	Server_id	End_log_pos	Info
>  master-bin.000001	#	Query	#	#	create database testing_1
>  master-bin.000001	#	Query	#	#	use `testing_1`; create table t1 (a int)
> @@ -97,7 +137,7 @@ insert into t1 values (1);
>  drop database if exists mysqltest1;
>  insert into t1 values (1);
>  drop table tt1, t1;
> -show binlog events from <binlog_start>;
> +show binlog events in 'master-bin.000001' from <binlog_start>;
>  Log_name	Pos	Event_type	Server_id	End_log_pos	Info
>  master-bin.000001	#	Query	#	#	use `test`; create table t1 (a int)
>  master-bin.000001	#	Query	#	#	BEGIN
> @@ -110,6 +150,26 @@ master-bin.000001	#	Table_map	#	#	table_
>  master-bin.000001	#	Write_rows	#	#	table_id: # flags: STMT_END_F
>  master-bin.000001	#	Query	#	#	COMMIT
>  master-bin.000001	#	Query	#	#	use `test`; DROP TABLE `t1` /* generated by server */
> +RESET master;
> +CREATE DATABASE test1;
> +USE test1;
> +CREATE TABLE t1(id int);
> +DROP DATABASE test1;
> +CREATE DATABASE test1;
> +USE test1;
> +CREATE TABLE t1(id int);
> +DROP TABLE t1;
> +DROP DATABASE test1;
> +FLUSH LOGS;
> +show binlog events in 'master-bin.000002' from <binlog_start>;
> +Log_name	Pos	Event_type	Server_id	End_log_pos	Info
> +master-bin.000002	#	Query	#	#	CREATE DATABASE test1
> +master-bin.000002	#	Query	#	#	use `test1`; CREATE TABLE t1(id int)
> +master-bin.000002	#	Query	#	#	DROP DATABASE test1
> +master-bin.000002	#	Query	#	#	CREATE DATABASE test1
> +master-bin.000002	#	Query	#	#	use `test1`; CREATE TABLE t1(id int)
> +master-bin.000002	#	Query	#	#	use `test1`; DROP TABLE t1
> +master-bin.000002	#	Query	#	#	DROP DATABASE test1
>  FLUSH STATUS;
>  show databases;
>  Database
> 
> === modified file 'sql/log_event.cc'
> --- a/sql/log_event.cc	2010-10-23 12:55:44 +0000
> +++ b/sql/log_event.cc	2010-12-07 06:58:31 +0000
> @@ -2894,7 +2894,9 @@ void Query_log_event::print_query_header
>                  error_code);
>    }
>  
> -  if (!(flags & LOG_EVENT_SUPPRESS_USE_F) && db)
> +  if (flags & LOG_EVENT_SUPPRESS_USE_F)
> +    print_event_info->db[0]= '\0';
> +  else if (db)
>    {
>      different_db= memcmp(print_event_info->db, db, db_len + 1);
>      if (different_db)
> 
> text/bzr-bundle type attachment
> (bzr/dao-gang.qu@stripped)
> # Bazaar merge directive format 2 (Bazaar 0.90)
> # revision_id: dao-gang.qu@stripped
> # target_branch: file:///home/daogang/bzrwork/bug50914/mysql-5.1-\
> #   bugteam/
> # testament_sha1: 3ceead548481af4aca1c2d6ddab170a021dcfbe6
> # timestamp: 2010-12-07 14:58:39 +0800
> # base_revision_id: azundris@stripped
> # 
> # Begin bundle
> IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWd/bYyMABuzfgGAwfff//3/n
> /67////0YAx+9z7O+et6ujsKFAjcnTu3Xx3Zyu2Jq6HW2tW1N73uwkkk2kGmpPGjTVPZKfiNSeI0
> mRoGQ0NDQAABJIIDQaBGkm0mERoBoNGgA0ABpo9QJJAmSjMQ0U/SQPU9T1NqNGhoaGg0AABoAaaE
> ppP1NQ9EDT0JoNAAaDINADIBoACKRDVT8jU2iMKY1MGqejTBPVHig0GmjIAeoDQRSCExNKT2IyMo
> 1M9U9R6jEH6oHqBpiNBoZBtJ9te6K/6iXA6ESET2viNGaJDSSGrkv1cVmFm1IGVSc0sQjBV9ZBoX
> /S/GQaVOVmYVJpmanalmQZWZXJ8kgOCri8BgAt87/GUGGj9Lq8IXlTNFsi+BU9VUNC12qgLFMJk+
> x4ohPHKAau9PFTaxawi7N7eNdsOIRb4Z+pD9zRwC4NoQkQxARCEV/hAItQ2QJ1rOimcsbBSGW7V1
> UxAWwRRK0nd8Q0CIkly8aytAgxi0HovSgCZ0Alq1PmuEPQEuhCiEAibxu8Hzh+3X7g4fiCG1uFgL
> +firEw5g7Zk5+Jr/iByjk4M8xQnrXX6yc8Q2E5BTJQ0x/PauQRnihcIqgwk1YQg73BBWBZHTzMPe
> FsQlB7rnlb2vCSvqRHpdaz4BY2aEfbVdQEAQUgS3nRXhsEu+/dNE06bNSpc105s1uPxhr2G2Kjwc
> M8adDhi+lpWh9fY0gVebaTEKEyceCqyXbO8hT1wd+j1DjclamAQUFivny0jUgCC8OwLg/YN+Wpuf
> Yw7FDTpenufCVTkBqxcjyCus5myGoHZfmqbxh43l6JYaGMKmfAV0U3Zu5bGvQlwJWeaAdDEQxEoJ
> J5aA7g5h5fYox9UpQCVmVNz49QOmJLsUzNYiGYdDScgaQM5+ucxWcKvRxFextawhfsJFrCtFDojp
> KypVkxrPeNxW+1zXOgoDUHMPYZFCZcE24hMLkrGZ9d53q09nJhqZJjZKYMA2Z6OfuHKKQk8MYLNG
> UEcTTBHrYKs5vF+ylrUdYJ1aqiJ9NTnxBOrc9O/G10J8d9pdGEhlnJVwZmHDtxchPu806SkjO+bh
> b3+N9KwrdwY8/Ay8NIqJX8l6FzON9Rq6T/o5gluDIMio6TcObAuZr1IRPDCPOx8DFqVxU80jkyA0
> rrBeAr3vIRbtnpLlHLI1KCxlC2SmNBS0YSvUs06iNxNRKn6HhNqh0zIw5KGU/q2rfunLv4WibqV/
> i8cJFQ65zqjUXccQU4m+3ZvgRORZbqrii9Fhh12j8SRQMQHHdTO+zoMpp5Mt6tspUVXBKEgejcYT
> x9iptKmJZp9DYklYljErUyfcraay0akrgdwaIxebD56z4cIcKyQJnLNaeBcufLHE2aGrTFUvVi5A
> o+TMmkK/AeZxpjyXb1WUhZN6yCrCx0JPjjoCqK+SbYhBnlR4DVfLQGawc3Z41HjSuxaTzJ4ybTrJ
> io62TrlmCdl3Rcy10dgO5RFdVgdtJwWENAVgU2smHEM4OTYAoEXCtJRoTe6xVDMwp5q4YFqdl9Ko
> rkUFw+0MnY+9fhQKR3aheaq3poWRDmThaNW0AsaDBRoRjtUTBM5rtMzA/5W2bxGtHqpZNhm5YE1Y
> TIDTMS3ZZU3RqpkJlgPMnvBxKKqIJyenFZo2QgpTNjprBSMdppx7xPLm3musMsb9wwLSWALUrrII
> i1Wi8tUcUnOkEotVloVSRFDQfKcBVA6DORGVIumlOjQ3eM9jM3GDHgjy74OBsCAhIasAe2LGk0N/
> eQ+1O3s2nTG2MIIiIjwDZNgDZmDRRDnOXc/TquvJPYj7VBxekF8Q/gV9aLWGm7SEJER+4L8IRMlL
> JH3DYBIYAhFsLCg0AowGPoPVRwBe9REgEJbkXP2k0mNAxIwGWAZg/7tgdtoGrSZntZonfWLP8wjJ
> QD1B38TrWyWYkekMhIzP0JrMPQ5Ez4JidqLoC41il4f0EagCAIBuCSdoe0JmAVDnNBNyahUFmiQU
> CEXTIHBzjpxs0yOeG5ABqBUVl4U1B5eLkneXlMRjO8frZ7PSp1kRD7wsaw21hIIIWra2LV2e+QE0
> IghbuKHKJL7jG0SXmeZ+hKllXy+UwAY856ceSrpYosSd5/wv/QK0bJWWVssujUE5/g4AtFpA1lmk
> as6FTlAdKIYhGBiwCXfnIuGYVvfQZeZ2KjZwrAqTr9wxaQEGAzGEjkvXiV4C9r9PAnzEEjrPMADk
> FiOJkdTri6IIOlN1IGgqzLPdqVqzZ+VAnZadDky22FQ9xC6mg0EedQ3+gImcaWNnpwWFry5xEbR4
> muc6ulljBNVehtbuZmF34tuVy2tgQLeyTIH4G++xmcNzYmpK049m0OKYxExR2sYChBAy8JUhgu5U
> 8Y1BYh9Si69x2c/S7GcDU5XL3ro37rXj8hroUHAiCicHhJfeC7qoWmnkUKsDcwmYEyauIHYm+FXm
> iJryTkGoLUkJ1yCvDieGI+DxE6YbN9DrI18ikyNed4hyhp8NYOSCUrAL1rsClJOk8UmYU1xne4JR
> lfzb+SCLuc07aodWnCRZ4YWotdi8K1y5BTJ7FCmISAgDoIQgIJDOlVXRG7hIbXv55GL4MmopVCeb
> yXxuJIu8IRWcM1MEx0DFmv7IhYEZokuV15BvhtBRyGwYYrBT8JnNWuA2GJxqeXT3+kisiRxhOowM
> k5o4hx2BrZBsTVHj3t51Lwajb32SHi6qZXXHCBxViJ9+hdUWqQR192bVtRm1oQgHyg2hZwkBXkDZ
> V2Vl02PDnCIdDIxTENy0RK64EKYRxy5EbdLv3t7yrVt9SCNChVNCrEh9QxbfVemsbt/OpahKVWQI
> Uzoq8NIRouGNQh2BABclCgnoFdcu1c+4X0d1zy23IpkuFgMbLZVHQIlsV2e28pknGUhDj7U2AMe8
> 2q5Gn4TmqW7Fvr08QN6XjyhkWeeb8O1ylBPLlecBzeQNfAlKpLcqkR3fx8SQtPN2LywCCYFHfDJW
> CMFrlcE+h9GRtv1czwabutCMIJzUIlLN3jpRIZB8psbqLaOVN848MfqpYluDmc7UHsy4Oux1w5BM
> HHDuTFeAEkOttDsa6RDC/SyoFKvcwhKCqIBg87MnmcdaiVXHNx92jCkMCwMEIQQwwRCJDGa/x7Q8
> rfxhLIoWI7pXlY6IyDfoFDyMK0bWxCiJkXpsuLueg2hDeuWbtm/eyc+D5y9fYpSBwjybx0oAK6e1
> gYTMHoIo3BVKray1augOlse6Wl9csjxwkyNFuzTrDJl1fS+CfK7udl8wN2/MAzMNuHeDlTO5zXII
> FdJzkkfLvFa9WnsaBqcH3cQcjJpC8/wzTI7mUi0D5Gbtyo5bULrYMr1jYsVkoKaCFzAJmGGRJwpI
> 9aA5BGlwRKSyi6yVaMuVNrnrdixCQwhG+CQQAWenXRjyMsw2Qb4JWKAYGrBb0K9Y3bqXtBc17nOc
> 6UpS4XFhsCqEd5dDAAGVDG2kTzghRZhNIwsmB5AStdj0Op3lqXzrQ1UiCUq57OYJWTaywWGTIYRt
> YGBYBgIRLXCjSaFhWBjgBEm8KoMwCDbWN0yzO42xQe7MV1wOTsCA0MAhuQuaaigE85eEzbCkQcZ6
> c9R5Np/P8CzsLWDJKpcA2Hg9JYAwOYbhe8VsYZFJT2gvjqhcr0bYoRJDeleJa8FvzrM+A4Etq1uI
> IpHLWE/Og0BEsIXQ1brykUwRKNTzApxHc8LJTW5SXE5+hmv1g9W6Jq+ZzdE8Qao3WUgiK1k3kzXS
> r85qOu6xoBaiR0taw27s3pyLe3tvWCo1WdAYbvJOrQUmHKjZvyIT1JEr9an/4u5IpwoSG/tsZGA=
> 
> 

-- 
Your Sincerely,
Libing Song
==================================
MySQL Replication Team
Software Engineer


Email : Li-Bing.Song@stripped
Skype : libing.song
MSN   : slb_database@stripped
Phone : +86 010-6505-4020 ext. 319
Mobile: +86 138-1144-2038
==================================

Thread
bzr commit into mysql-5.1-bugteam branch (Dao-Gang.Qu:3521) Bug#50914Dao-Gang.Qu7 Dec
  • Re: bzr commit into mysql-5.1-bugteam branch (Dao-Gang.Qu:3521)Bug#50914Libing Song10 Dec
    • Re: bzr commit into mysql-5.1-bugteam branch (Dao-Gang.Qu:3521)Bug#50914Daogang Qu13 Dec
      • Re: bzr commit into mysql-5.1-bugteam branch (Dao-Gang.Qu:3521)Bug#50914Libing Song13 Dec
        • Re: bzr commit into mysql-5.1-bugteam branch (Dao-Gang.Qu:3521)Bug#50914Daogang Qu14 Dec
    • Re: bzr commit into mysql-5.1-bugteam branch (Dao-Gang.Qu:3521)Bug#50914Daogang Qu13 Dec