From: Sergey Vojtovich
Date: December 9 2010 2:42pm
Subject: Re: bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3511)
 Bug#54486
List-Archive: http://lists.mysql.com/commits/126431
Message-Id: <20101209144247.GA2939@june>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Dmitry,

On Thu, Dec 09, 2010 at 08:27:33PM +0600, Dmitry Shulga wrote:
> 
> On 09.12.2010, at 16:06, Sergey Vojtovich wrote:
> 
> > Hi Dmitry,
> > 
> > ok to push, but there are a few minor suggestions inline.
> > 
> >>     @ sql/sql_db.cc
> >>        mysql_rm_known_files() modified: ignore possible errors
> >>        when trying delete all table's files. Such aggressigve 
> >>        algorithm permits skip already deleted (in another thread)
> >>        files.
> > Hmm... it doesn't sound up to date.
> Why do you think so?
This comment is inherited from the first patch, where you ignore
all errors "when trying delete all table's files". Now you only
ignore ENOENT.

...skip...

Regards,
Sergey
-- 
Sergey Vojtovich <svoj@stripped>
MySQL AB, Software Engineer
Izhevsk, Russia, www.mysql.com