List:Commits« Previous MessageNext Message »
From:Jorgen Loland Date:December 8 2010 12:55pm
Subject:Re: bzr commit into mysql-trunk-bugfixing branch (tor.didriksen:3257)
Bug#58756 Bug#58761
View as plain text  
Hi Tor,

Approved pending minor changes as described inline

On 12/07/2010 01:30 PM, Tor Didriksen wrote:
> #At file:///export/home/didrik/repo/next-mr-opt-team-wl1393-merge/ based on
> revid:tor.didriksen@stripped
>
>   3257 Tor Didriksen	2010-12-07
>        Bug #58756 Crash in heap_rrnd on query with HAVING ... IN (subquery) + LIMIT
>        Bug #58761 Crash in Field::is_null in field.h on subquery in WHERE clause

Please use a sentence or two to describe the problem.

>       @ mysql-test/include/order_by.inc
>          New test case
>       @ mysql-test/r/bug58756.result
>          New test case.
>       @ mysql-test/r/order_by_icp_mrr.result
>          New test case.
>       @ mysql-test/r/order_by_none.result
>          New test case.

For the record, we have discussed the wrong test output offline. Fixed in 
followup patch.

>       @ mysql-test/t/bug58756.test
>          New test case.
>       @ sql/filesort.cc
>          In save_index: allocate and copy record pointers for 'count' keys.
>       @ sql/sql_select.cc
>          table->sort.found_records is used in init_read_record(), don't set it to
> found_rows.
>          Instead: use tab->records to set thd->limit_found_rows, since
> filesort()
>          now always return number of found_rows.
>
>      added:
>        mysql-test/r/bug58756.result
>        mysql-test/t/bug58756.test

Did you consider adding this test to subselect_innodb.test? Consider it and do 
as you please.

>      modified:
>        mysql-test/include/order_by.inc
>        mysql-test/r/order_by_icp_mrr.result
>        mysql-test/r/order_by_none.result
>        sql/filesort.cc
>        sql/sql_select.cc
> === modified file 'mysql-test/include/order_by.inc'
> --- a/mysql-test/include/order_by.inc	2010-11-30 11:54:00 +0000
> +++ b/mysql-test/include/order_by.inc	2010-12-07 12:30:31 +0000
> @@ -1523,6 +1523,42 @@ DROP VIEW v1, v2;
>   --echo # end of WL#1393 - Optimizing filesort with small limit
>
>   #
> +# Bug #58761 Crash in Field::is_null in field.h on subquery in WHERE clause
> +#

Please --echo this meta info


-- 
Jørgen Løland | Senior Software Engineer | +47 73842138
Oracle MySQL
Trondheim, Norway
Thread
bzr commit into mysql-trunk-bugfixing branch (tor.didriksen:3257) Bug#58756Bug#58761Tor Didriksen7 Dec
  • Re: bzr commit into mysql-trunk-bugfixing branch (tor.didriksen:3257)Bug#58756 Bug#58761Jorgen Loland8 Dec
    • Re: bzr commit into mysql-trunk-bugfixing branch (tor.didriksen:3257)Bug#58756 Bug#58761Tor Didriksen9 Dec