List:Commits« Previous MessageNext Message »
From:Luís Soares Date:December 7 2010 12:21pm
Subject:Re: bzr commit into mysql-trunk branch (andrei.elkin:3210) Bug#58753
View as plain text  
Hi Andrei,
   Please find my review comments below.

STATUS
------

   Not approved.

REQUIRED CHANGES
----------------
  n/a

REQUESTS
--------

   R1. Please, enlighten me! Why is this a sporadic failure?

   R2. Aren't all tests vulnerable when checksums are active in
       MTR? If they are, wouldn't it be better to place the
       warning in include/mtr_warnings.sql ?

SUGGESTIONS
-----------
  n/a

DETAILS
-------
  n/a

On 12/06/2010 01:08 PM, Andrei Elkin wrote:
> #At file:///home/andrei/MySQL/BZR/2a-23May/mysql-trunk/ based on
> revid:alexander.nozdrin@stripped
>
>   3210 Andrei Elkin	2010-12-06
>        Bug #58753 rpl_checksum finds unsuppressed warning
>
>        Suppressed a warning allowed by the test's logics.
>       @ mysql-test/suite/rpl/r/rpl_checksum.result
>          results are updated.
>       @ mysql-test/suite/rpl/t/rpl_checksum.test
>          suppression is added.
>
Thread
bzr commit into mysql-trunk branch (andrei.elkin:3210) Bug#58753Andrei Elkin6 Dec
  • Re: bzr commit into mysql-trunk branch (andrei.elkin:3210) Bug#58753Luís Soares7 Dec
Re: bzr commit into mysql-trunk branch (andrei.elkin:3210) Bug#58753Luís Soares9 Dec