List:Commits« Previous MessageNext Message »
From:Alex Ivanov Date:January 18 2006 12:02pm
Subject:bk commit into 5.0 tree (aivanov:1.2030)
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of alexi. When alexi does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2030 06/01/18 15:02:03 aivanov@stripped +6 -0
  Applied patch recieved from Marko:
   Make innodb_flush_log_at_trx_commit a settable global variable.

  sql/set_var.cc
    1.147 06/01/18 15:01:54 aivanov@stripped +5 -1
    Make innodb_flush_log_at_trx_commit a settable global variable.

  sql/mysqld.cc
    1.530 06/01/18 15:01:54 aivanov@stripped +2 -2
    Bypass the variable innobase innobase_flush_log_at_trx_commit.

  sql/ha_innodb.h
    1.109 06/01/18 15:01:54 aivanov@stripped +1 -1
    Remove innobase_flush_log_at_trx_commit.
     (Set srv_flush_log_at_trx_commit directly).

  sql/ha_innodb.cc
    1.284 06/01/18 15:01:53 aivanov@stripped +1 -3
    Remove innobase_flush_log_at_trx_commit.
     (Set srv_flush_log_at_trx_commit directly).

  innobase/srv/srv0srv.c
    1.96 06/01/18 15:01:53 aivanov@stripped +1 -1
    Change the type of srv_flush_log_at_trx_commit.

  innobase/include/srv0srv.h
    1.59 06/01/18 15:01:53 aivanov@stripped +1 -1
    Change the type of srv_flush_log_at_trx_commit.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	aivanov
# Host:	mysql.creware.com
# Root:	/home/alexi/innodb-ss/mysql-5.0-ss-patches

--- 1.529/sql/mysqld.cc	2006-01-12 21:28:18 +03:00
+++ 1.530/sql/mysqld.cc	2006-01-18 15:01:54 +03:00
@@ -4823,8 +4823,8 @@
    (gptr*) &innobase_file_per_table, 0, GET_BOOL, NO_ARG, 0, 0, 0, 0, 0, 0},
   {"innodb_flush_log_at_trx_commit", OPT_INNODB_FLUSH_LOG_AT_TRX_COMMIT,
    "Set to 0 (write and flush once per second), 1 (write and flush at each commit) or 2 (write at commit, flush once per second).",
-   (gptr*) &innobase_flush_log_at_trx_commit,
-   (gptr*) &innobase_flush_log_at_trx_commit,
+   (gptr*) &srv_flush_log_at_trx_commit,
+   (gptr*) &srv_flush_log_at_trx_commit,
    0, GET_UINT, OPT_ARG,  1, 0, 2, 0, 0, 0},
   {"innodb_flush_method", OPT_INNODB_FLUSH_METHOD,
    "With which method to flush data.", (gptr*) &innobase_unix_file_flush_method,

--- 1.58/innobase/include/srv0srv.h	2005-12-13 21:35:14 +03:00
+++ 1.59/innobase/include/srv0srv.h	2006-01-18 15:01:53 +03:00
@@ -77,7 +77,7 @@
 extern ulint	srv_n_log_files;
 extern ulint	srv_log_file_size;
 extern ulint	srv_log_buffer_size;
-extern ulint	srv_flush_log_at_trx_commit;
+extern ulong	srv_flush_log_at_trx_commit;
 
 extern byte	srv_latin1_ordering[256];/* The sort order table of the latin1
 					character set */

--- 1.95/innobase/srv/srv0srv.c	2005-12-13 21:35:14 +03:00
+++ 1.96/innobase/srv/srv0srv.c	2006-01-18 15:01:53 +03:00
@@ -113,7 +113,7 @@
 ulint	srv_n_log_files		= ULINT_MAX;
 ulint	srv_log_file_size	= ULINT_MAX;	/* size in database pages */ 
 ulint	srv_log_buffer_size	= ULINT_MAX;	/* size in database pages */ 
-ulint	srv_flush_log_at_trx_commit = 1;
+ulong	srv_flush_log_at_trx_commit = 1;
 
 byte	srv_latin1_ordering[256]	/* The sort order table of the latin1
 					character set. The following table is

--- 1.283/sql/ha_innodb.cc	2006-01-16 15:22:53 +03:00
+++ 1.284/sql/ha_innodb.cc	2006-01-18 15:01:53 +03:00
@@ -167,7 +167,6 @@
 /* Below we have boolean-valued start-up parameters, and their default
 values */
 
-uint	innobase_flush_log_at_trx_commit	= 1;
 ulong	innobase_fast_shutdown			= 1;
 my_bool innobase_log_archive			= FALSE;/* unused */
 my_bool innobase_use_doublewrite    = TRUE;
@@ -1341,7 +1340,6 @@
 	srv_log_archive_on = (ulint) innobase_log_archive;
 #endif /* UNIV_LOG_ARCHIVE */
 	srv_log_buffer_size = (ulint) innobase_log_buffer_size;
-	srv_flush_log_at_trx_commit = (ulint) innobase_flush_log_at_trx_commit;
 
         /* We set srv_pool_size here in units of 1 kB. InnoDB internally
         changes the value so that it becomes the number of database pages. */
@@ -1816,7 +1814,7 @@
 
                 trx->active_trans = 0;
 
-                if (srv_flush_log_at_trx_commit == 0) {
+                if (UNIV_UNLIKELY(srv_flush_log_at_trx_commit == 0)) {
 
                         return(0);
                 }

--- 1.108/sql/ha_innodb.h	2005-12-06 22:02:30 +03:00
+++ 1.109/sql/ha_innodb.h	2006-01-18 15:01:54 +03:00
@@ -200,7 +200,6 @@
 
 extern struct show_var_st innodb_status_variables[];
 extern uint innobase_init_flags, innobase_lock_type;
-extern uint innobase_flush_log_at_trx_commit;
 extern ulong innobase_cache_size, innobase_fast_shutdown;
 extern ulong innobase_large_page_size;
 extern char *innobase_home, *innobase_tmpdir, *innobase_logdir;
@@ -238,6 +237,7 @@
 extern ulong srv_thread_sleep_delay;
 extern ulong srv_thread_concurrency;
 extern ulong srv_commit_concurrency;
+extern ulong srv_flush_log_at_trx_commit;
 }
 
 extern TYPELIB innobase_lock_typelib;

--- 1.146/sql/set_var.cc	2006-01-03 19:54:36 +03:00
+++ 1.147/sql/set_var.cc	2006-01-18 15:01:54 +03:00
@@ -422,6 +422,9 @@
                                                 &srv_thread_concurrency);
 sys_var_long_ptr  sys_innodb_commit_concurrency("innodb_commit_concurrency",
                                                 &srv_commit_concurrency);
+sys_var_long_ptr  sys_innodb_flush_log_at_trx_commit(
+                                        "innodb_flush_log_at_trx_commit",
+                                        &srv_flush_log_at_trx_commit);
 #endif
 
 /* Condition pushdown to storage engine */
@@ -726,6 +729,7 @@
   &sys_innodb_thread_sleep_delay,
   &sys_innodb_thread_concurrency,
   &sys_innodb_commit_concurrency,
+  &sys_innodb_flush_log_at_trx_commit,
 #endif  
   &sys_trust_routine_creators,
   &sys_trust_function_creators,
@@ -831,7 +835,6 @@
   {sys_innodb_fast_shutdown.name,(char*) &sys_innodb_fast_shutdown, SHOW_SYS},
   {"innodb_file_io_threads", (char*) &innobase_file_io_threads, SHOW_LONG },
   {"innodb_file_per_table", (char*) &innobase_file_per_table, SHOW_MY_BOOL},
-  {"innodb_flush_log_at_trx_commit", (char*) &innobase_flush_log_at_trx_commit, SHOW_INT},
   {"innodb_flush_method",    (char*) &innobase_unix_file_flush_method, SHOW_CHAR_PTR},
   {"innodb_force_recovery", (char*) &innobase_force_recovery, SHOW_LONG },
   {"innodb_lock_wait_timeout", (char*) &innobase_lock_wait_timeout, SHOW_LONG },
@@ -851,6 +854,7 @@
   {sys_innodb_table_locks.name, (char*) &sys_innodb_table_locks, SHOW_SYS},
   {sys_innodb_thread_concurrency.name, (char*) &sys_innodb_thread_concurrency, SHOW_SYS},
   {sys_innodb_thread_sleep_delay.name, (char*) &sys_innodb_thread_sleep_delay, SHOW_SYS},
+  {sys_innodb_flush_log_at_trx_commit.name, (char*) &sys_innodb_flush_log_at_trx_commit, SHOW_SYS},
 #endif
   {sys_interactive_timeout.name,(char*) &sys_interactive_timeout,   SHOW_SYS},
   {sys_join_buffer_size.name,   (char*) &sys_join_buffer_size,	    SHOW_SYS},
Thread
bk commit into 5.0 tree (aivanov:1.2030)Alex Ivanov18 Jan