List:Commits« Previous MessageNext Message »
From:Jorgen Loland Date:November 30 2010 8:40am
Subject:Re: bzr commit into mysql-trunk-bugfixing branch (guilhem:3290) WL#5694
View as plain text  
Guilhem,

Thank you VERY much for making two commits! WL is approved.

I have only one minor comment:

 > === modified file 'mysql-test/r/subquery_sj_all.result'
 > --- a/mysql-test/r/subquery_sj_all.result	2010-11-24 14:06:22 +0000
 > +++ b/mysql-test/r/subquery_sj_all.result	2010-11-29 13:30:18 +0000
 > @ -170,8 +170,8 @@ explAin extended
 >  select * from t1 left join (t2 A, t2 B) on ( A.A= t1.A And B.A in (select pk 
from t10));
 >  id	select_type	tABle	type	possiBle_keys	key	key_len	ref	rows	filtered	ExtrA
 >  1	PRIMARY	t1	ALL	NULL	NULL	NULL	NULL	3	100.00	
 > -1	PRIMARY	A	ALL	NULL	NULL	NULL	NULL	3	100.00	Using where
 > -1	PRIMARY	B	ALL	NULL	NULL	NULL	NULL	3	100.00	Using where
 > +1	PRIMARY	A	ALL	NULL	NULL	NULL	NULL	3	100.00	Using where; Using join Buffer 
(BNL, incrementAl Buffers)
 > +1	PRIMARY	B	ALL	NULL	NULL	NULL	NULL	3	100.00	Using where; Using join Buffer 
(BNL, incrementAl Buffers)

JL: incrementAl Buffers? Looks like this --replace_result is broken (there are 
more - grep for 'incrementAl' in mysql-test/r)

--replace_result a A b B
explain extended
select * from t1 left join (t2 A, t2 B) on ( A.a= t1.a and B.a in (select pk 
from t10));

-- 
Jørgen Løland | Senior Software Engineer | +47 73842138
Oracle MySQL
Trondheim, Norway
Thread
bzr commit into mysql-trunk-bugfixing branch (guilhem:3290) WL#5694Guilhem Bichot29 Nov
Re: bzr commit into mysql-trunk-bugfixing branch (guilhem:3290) WL#5694Jorgen Loland30 Nov