List:Commits« Previous MessageNext Message »
From:Luis Soares Date:November 27 2010 11:51am
Subject:bzr commit into mysql-5.1-bugteam branch (luis.soares:3523) Bug#58416
View as plain text  
#At file:///home/lsoares/Workspace/bzr/work/bugfixing/58416/mysql-5.1-bugteam/ based on revid:georgi.kodinov@stripped

 3523 Luis Soares	2010-11-27
      BUG#58416: binlog.binlog_row_failure_mixing_engines fails on 
      win x86 debug_max
      
      The windows MTR run exhibited a different test execution 
      ordering (due to the fact that in these platforms MTR is invoked
      with --parallel > 1). This uncovered a bug in the aforementioned
      test case, which is triggered by the following conditions:
      
        1. server is not restarted between two different tests;
        2. the test before binlog.binlog_row_failure_mixing_engines
           issues flush logs;
        3. binlog.binlog_row_failure_mixing_engines uses binlog
           positions to limit the output of show_binlog_events;
        4. binlog.binlog_row_failure_mixing_engines does not state which
           binlog file to use, thence it uses a wrong binlog file with
           the correct position.
      
      There are two possible fixes: 1. make sure that the test start 
      from a clean slate - binlog wise; 2. in addition to the position, 
      also state the binary log file before sourcing 
      show_binlog_events.inc .
      
      We go for fix #1, ie, deploy a RESET MASTER before the test is 
      actually started.

    modified:
      mysql-test/extra/binlog_tests/binlog_failure_mixing_engines.test
      mysql-test/suite/binlog/r/binlog_mixed_failure_mixing_engines.result
      mysql-test/suite/binlog/r/binlog_row_failure_mixing_engines.result
=== modified file 'mysql-test/extra/binlog_tests/binlog_failure_mixing_engines.test'
--- a/mysql-test/extra/binlog_tests/binlog_failure_mixing_engines.test	2009-10-06 00:54:00 +0000
+++ b/mysql-test/extra/binlog_tests/binlog_failure_mixing_engines.test	2010-11-27 11:51:07 +0000
@@ -60,6 +60,7 @@
 # Please, remove this test case after pushing WL#2687.
 ################################################################################
 
+RESET MASTER;
 
 --echo ###################################################################################
 --echo #                                   CONFIGURATION

=== modified file 'mysql-test/suite/binlog/r/binlog_mixed_failure_mixing_engines.result'
--- a/mysql-test/suite/binlog/r/binlog_mixed_failure_mixing_engines.result	2009-10-06 00:54:00 +0000
+++ b/mysql-test/suite/binlog/r/binlog_mixed_failure_mixing_engines.result	2010-11-27 11:51:07 +0000
@@ -1,3 +1,4 @@
+RESET MASTER;
 ###################################################################################
 #                                   CONFIGURATION
 ###################################################################################

=== modified file 'mysql-test/suite/binlog/r/binlog_row_failure_mixing_engines.result'
--- a/mysql-test/suite/binlog/r/binlog_row_failure_mixing_engines.result	2009-10-06 00:54:00 +0000
+++ b/mysql-test/suite/binlog/r/binlog_row_failure_mixing_engines.result	2010-11-27 11:51:07 +0000
@@ -1,3 +1,4 @@
+RESET MASTER;
 ###################################################################################
 #                                   CONFIGURATION
 ###################################################################################


Attachment: [text/bzr-bundle] bzr/luis.soares@oracle.com-20101127115107-nocym9p5w44egi42.bundle
Thread
bzr commit into mysql-5.1-bugteam branch (luis.soares:3523) Bug#58416Luis Soares27 Nov