List:Commits« Previous MessageNext Message »
From:Jon Olav Hauglid Date:November 25 2010 3:59pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3511)
Bug#54486
View as plain text  
Hello!

On 11/19/2010 06:43 AM, Dmitry Shulga wrote:
>
>   3511 Dmitry Shulga	2010-11-19
>        Fixed bug#54486 - assert in my_seek, concurrent
>        DROP/CREATE SCHEMA, CREATE TABLE, REPAIR.

Just two initial comments about your patch:

>      modified:
>        sql/sql_db.cc
>        storage/myisam/mi_check.c

Have you tried making a regression test for this bug?

> === modified file 'sql/sql_db.cc'
> --- a/sql/sql_db.cc	2010-10-19 10:27:09 +0000
> +++ b/sql/sql_db.cc	2010-11-19 05:43:28 +0000
> @@ -985,6 +985,9 @@ bool mysql_rm_db(THD *thd,char *db,bool
>       }
>       thd->pop_internal_handler();
>     }
> +  DBUG_ASSERT(deleted>= 0 ||
> +              (deleted<  0&&  thd->main_da.is_set()));
> +

I was able to trigger this assert by running the
rpl.rpl_killed_ddl test case. Could you check if
this happens for you as well?

Thanks,

--- Jon Olav
Thread
bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3511) Bug#54486Dmitry Shulga19 Nov
  • Re: bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3511)Bug#54486Jon Olav Hauglid25 Nov
  • Re: bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3511)Bug#54486Sergey Vojtovich26 Nov
    • Re: bzr commit into mysql-5.1-bugteam branch (Dmitry.Shulga:3511) Bug#54486Dmitry Shulga29 Nov