List:Commits« Previous MessageNext Message »
From:Alfranio Correia Date:November 22 2010 12:19pm
Subject:Re: bzr commit into mysql-5.5-bugteam branch (alfranio.correia:3122)
Bug#57275
View as plain text  
Hi Andrei,

I already has received his blessing on this matter.
Texts were submitted to his appreciation before committing the patch.

Jon if you have any other holy advice, let me know.

Cheers.

On 11/22/2010 12:12 PM, Andrei Elkin wrote:
> Alfranio, hello.
>
> The patch looks nice.
> I have few comments on the new/old var/status description text.
> Could please address those and master-Jon :-) the final version.
>
> thanks!
>
> Andrei
>
>
>>
>>   static Sys_var_ulong Sys_binlog_cache_size(
>> -       "binlog_cache_size", "The size of the cache to "
>> -       "hold the SQL statements for the binary log during a "
>> -       "transaction. If you often use big, multi-statement "
>> -       "transactions you can increase this to get more performance",
>> +       "binlog_cache_size", "The size of the transactional cache for "
>> +       "updates to transactional engines for the binary log. "
>> +       "If you often use transactions containing many statements, "
>> +       "you can increase this to get more performance",
>>          GLOBAL_VAR(binlog_cache_size),
>>          CMD_LINE(REQUIRED_ARG),
>>          VALID_RANGE(IO_SIZE, ULONG_MAX), DEFAULT(32768), BLOCK_SIZE(IO_SIZE));
>>
>> +static Sys_var_ulong Sys_binlog_stmt_cache_size(
>> +       "binlog_stmt_cache_size", "The size of the statement cache for "
>> +       "updates to non-transactional engines for the binary log. "
>> +       "If you often use statements updating a great number of rows, "
>> +       "you can increase this to get more performance",
>
> Notice the word `statement' is referred twice in different contexts
> within the block.
>
> Also I would not recommend `you' to suggest the passive voice instead. E.g
> If a query updates ... the value of binlog_stmt_cache_size can be increased...
>
>
>> +       GLOBAL_VAR(binlog_stmt_cache_size),
>> +       CMD_LINE(REQUIRED_ARG),
>> +       VALID_RANGE(IO_SIZE, ULONG_MAX), DEFAULT(32768), BLOCK_SIZE(IO_SIZE));
>> +
>>   static bool check_has_super(sys_var *self, THD *thd, set_var *var)
>>   {
>>     DBUG_ASSERT(self->scope() != sys_var::GLOBAL);// don't abuse
> check_has_super()
>> @@ -1031,13 +1040,20 @@ static Sys_var_ulong Sys_max_allowed_pac
>>
>>   static Sys_var_ulonglong Sys_max_binlog_cache_size(
>>          "max_binlog_cache_size",
>> -       "Can be used to restrict the total size used to cache a "
>> -       "multi-transaction query",
>
>> +       "Sets the total size of the transactional cache",
>
> Does not it actually set the *limit* size?
>
>>          GLOBAL_VAR(max_binlog_cache_size), CMD_LINE(REQUIRED_ARG),
>>          VALID_RANGE(IO_SIZE, ULONGLONG_MAX),
>>          DEFAULT((ULONGLONG_MAX/IO_SIZE)*IO_SIZE),
>>          BLOCK_SIZE(IO_SIZE));
>>
>> +static Sys_var_ulonglong Sys_max_binlog_stmt_cache_size(
>> +       "max_binlog_stmt_cache_size",
>
>> +       "Sets the total size of the statement cache",
>
> same as above.
>
>> +       GLOBAL_VAR(max_binlog_stmt_cache_size), CMD_LINE(REQUIRED_ARG),
>> +       VALID_RANGE(IO_SIZE, ULONGLONG_MAX),
>> +       DEFAULT((ULONGLONG_MAX/IO_SIZE)*IO_SIZE),
>> +       BLOCK_SIZE(IO_SIZE));
>> +
>>   static bool fix_max_binlog_size(sys_var *self, THD *thd, enum_var_type type)
>>   {
>>     mysql_bin_log.set_max_size(max_binlog_size);
>>

Thread
Re: bzr commit into mysql-5.5-bugteam branch (alfranio.correia:3122)Bug#57275Alfranio Correia22 Nov