From: Jon Olav Hauglid Date: November 22 2010 11:21am Subject: bzr push into mysql-5.5-bugteam branch (jon.hauglid:3126 to 3127) List-Archive: http://lists.mysql.com/commits/124613 Message-Id: <201011221122.oAM931kL020425@acsinet15.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit 3127 Jon Olav Hauglid 2010-11-22 This patch fixes the bug which caused the funcs_1.storedproc test case to give valgrind warnings. The problem was that when comparing two MDL key buffers using memcmp(), 1 was added to the buffer length. However, this was no longer needed since the buffer length already included the '\0' terminator. modified: sql/mdl.h 3126 Davi Arnaut 2010-11-22 WL#5665: Removal of the autotools-based build system Remove some more files which are unused. @ win/README This information is dated and does not apply anymore. @ win/create_manifest.js Unused. @ win/mysql_manifest.cmake Unused. removed: win/README win/create_manifest.js win/mysql_manifest.cmake === modified file 'sql/mdl.h' --- a/sql/mdl.h 2010-11-11 17:11:05 +0000 +++ b/sql/mdl.h 2010-11-22 10:50:20 +0000 @@ -252,7 +252,7 @@ public: character set is utf-8, we can safely assume that no character starts with a zero byte. */ - return memcmp(m_ptr, rhs->m_ptr, min(m_length, rhs->m_length)+1); + return memcmp(m_ptr, rhs->m_ptr, min(m_length, rhs->m_length)); } MDL_key(const MDL_key *rhs) No bundle (reason: useless for push emails).