List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:November 19 2010 12:46pm
Subject:Re: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790
View as plain text  
On 11/19/10 10:41 AM, Vladislav Vaintroub wrote:
>
>
>> -----Original Message----- From: Davi Arnaut
>> [mailto:davi.arnaut@stripped] Sent: Friday, November 19, 2010
>> 1:08 PM To: Vladislav Vaintroub Cc: commits@stripped
>> Subject: Re: bzr commit into mysql-5.5-runtime branch (davi:3186)
>> Bug#54790
>>
>> On 11/19/10 9:48 AM, Vladislav Vaintroub wrote:
>>>>>>> end up with WaitForSingleObject in an optimized version.
>>>>>
>>>>> Asynchronous I/O is nice and all, but its not viable to
>>>>> change the server design to adapt to the pattern of
>>>>> overlapped I/O. We should be looking for alternative that fit
>>>>> our pattern, not the other way around.
>>> The only thing we can have is poll()..
>>
>> and WSAEventSelect. This is the sad reality given the
>> requirements.
>
> The reality  has been so far closesocket().   What was the real
> problem with it? I think it is pretty good and reliable thing to

The problem with it is that there will be attempts to read or write from 
invalid sockets. This is race prone and simply wrong. In order to 
implement it properly we would require quite a bit of locking.

> break the read and write..  Even if current command deep in optimizer
> would like to say  its last words  before it dies , why care? It is

This work is for 5.5, my goal was not to re-design the server due to the 
lack of proper support for canceling I/O across the platforms that we 
have to support.

Vlad, our conversation is not going to move forward if you keep focusing 
on adjusting everything else to fit the pattern that you would like to see.

> going to die anyway, as somebody have chosen to kill it. So end user
> (client library) gets a socket error, which it must be prepared for,
> socket error are quite common in the TCP/IP.

Citation needed.

Regards,

Davi
Thread
bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Davi Arnaut16 Nov
Re: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Davi Arnaut18 Nov
  • RE: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Vladislav Vaintroub19 Nov
    • Re: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Davi Arnaut19 Nov
      • RE: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Vladislav Vaintroub19 Nov
        • Re: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Davi Arnaut19 Nov
          • RE: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Vladislav Vaintroub19 Nov
            • Re: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Davi Arnaut19 Nov
            • Re: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Davi Arnaut19 Nov
              • RE: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Vladislav Vaintroub19 Nov
                • Re: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Davi Arnaut19 Nov
                  • RE: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Vladislav Vaintroub19 Nov
                    • Re: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Davi Arnaut19 Nov
RE: bzr commit into mysql-5.5-runtime branch (davi:3186) Bug#54790Vladislav Vaintroub19 Nov