From: Tor Didriksen Date: November 19 2010 12:34pm Subject: bzr commit into mysql-trunk-bugfixing branch (tor.didriksen:3365) List-Archive: http://lists.mysql.com/commits/124434 Message-Id: <20101119123501.4415637A1@atum07.norway.sun.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5530919088949431592==" --===============5530919088949431592== MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline #At file:///export/home/didrik/repo/trunk-bugfixing/ based on revid:bjorn.munch@stripped 3365 Tor Didriksen 2010-11-19 Fix failing unit test after MDL interface change. modified: sql/mdl.cc unittest/gunit/mdl-t.cc unittest/gunit/mdl_mytap-t.cc === modified file 'sql/mdl.cc' --- a/sql/mdl.cc 2010-11-18 16:34:56 +0000 +++ b/sql/mdl.cc 2010-11-19 12:34:44 +0000 @@ -753,9 +753,9 @@ MDL_context::MDL_context() void MDL_context::destroy() { - DBUG_ASSERT(m_tickets[MDL_STATEMENT].is_empty() && - m_tickets[MDL_TRANSACTION].is_empty() && - m_tickets[MDL_EXPLICIT].is_empty()); + DBUG_ASSERT(m_tickets[MDL_STATEMENT].is_empty()); + DBUG_ASSERT(m_tickets[MDL_TRANSACTION].is_empty()); + DBUG_ASSERT(m_tickets[MDL_EXPLICIT].is_empty()); mysql_prlock_destroy(&m_LOCK_waiting_for); } === modified file 'unittest/gunit/mdl-t.cc' --- a/unittest/gunit/mdl-t.cc 2010-11-18 16:34:56 +0000 +++ b/unittest/gunit/mdl-t.cc 2010-11-19 12:34:44 +0000 @@ -292,8 +292,9 @@ TEST_F(MDL_DeathTest, die_when_m_tickets MDL_TRANSACTION); EXPECT_FALSE(m_mdl_context.try_acquire_lock(&m_request)); - EXPECT_DEATH(m_mdl_context.destroy(), ".*Assertion .*m_tickets.is_empty.*"); - m_mdl_context.release_all_locks_for_name(m_request.ticket); + EXPECT_DEATH(m_mdl_context.destroy(), + ".*Assertion.*MDL_TRANSACTION.*is_empty.*"); + m_mdl_context.release_transactional_locks(); } #endif // GTEST_HAS_DEATH_TEST && !defined(DBUG_OFF) @@ -326,7 +327,7 @@ void MDL_test::test_one_simple_shared_lo EXPECT_FALSE(m_mdl_context.try_acquire_lock(&request_2)); EXPECT_EQ(m_request.ticket, request_2.ticket); - m_mdl_context.release_all_locks_for_name(m_request.ticket); + m_mdl_context.release_transactional_locks(); EXPECT_FALSE(m_mdl_context.has_locks()); } @@ -391,8 +392,7 @@ TEST_F(MDL_test, one_exclusive) is_lock_owner(MDL_key::GLOBAL, "", "", MDL_INTENTION_EXCLUSIVE)); EXPECT_TRUE(m_request.ticket->is_upgradable_or_exclusive()); - m_mdl_context.release_all_locks_for_name(m_request.ticket); - m_mdl_context.release_lock(m_global_request.ticket); + m_mdl_context.release_transactional_locks(); EXPECT_FALSE(m_mdl_context.has_locks()); } @@ -404,10 +404,8 @@ TEST_F(MDL_test, one_exclusive) TEST_F(MDL_test, two_shared) { MDL_request request_2; - m_request.init(MDL_key::TABLE, db_name, table_name1, MDL_SHARED, - MDL_TRANSACTION); - request_2.init(MDL_key::TABLE, db_name, table_name2, MDL_SHARED, - MDL_TRANSACTION); + m_request.init(MDL_key::TABLE, db_name, table_name1, MDL_SHARED, MDL_EXPLICIT); + request_2.init(MDL_key::TABLE, db_name, table_name2, MDL_SHARED, MDL_EXPLICIT); EXPECT_FALSE(m_mdl_context.try_acquire_lock(&m_request)); EXPECT_FALSE(m_mdl_context.try_acquire_lock(&request_2)); @@ -457,8 +455,8 @@ TEST_F(MDL_test, shared_locks_between_co EXPECT_TRUE(mdl_context2. is_lock_owner(MDL_key::TABLE, db_name, table_name1, MDL_SHARED)); - m_mdl_context.release_all_locks_for_name(m_request.ticket); - mdl_context2.release_all_locks_for_name(request_2.ticket); + m_mdl_context.release_transactional_locks(); + mdl_context2.release_transactional_locks(); } @@ -483,8 +481,7 @@ TEST_F(MDL_test, upgrade_shared_upgradab upgrade_shared_lock_to_exclusive(m_request.ticket, long_timeout)); EXPECT_EQ(MDL_EXCLUSIVE, m_request.ticket->get_type()); - m_mdl_context.release_all_locks_for_name(m_request.ticket); - m_mdl_context.release_lock(m_global_request.ticket); + m_mdl_context.release_transactional_locks(); } @@ -589,7 +586,7 @@ TEST_F(MDL_test, concurrent_shared) release_locks.notify(); mdl_thread.join(); - m_mdl_context.release_all_locks_for_name(m_request.ticket); + m_mdl_context.release_transactional_locks(); } @@ -627,8 +624,7 @@ TEST_F(MDL_test, concurrent_shared_exclu EXPECT_FALSE(m_mdl_context.acquire_locks(&m_request_list, zero_timeout)); EXPECT_NE(m_null_ticket, m_request.ticket); - m_mdl_context.release_all_locks_for_name(m_request.ticket); - m_mdl_context.release_lock(m_global_request.ticket); + m_mdl_context.release_transactional_locks(); } @@ -659,7 +655,7 @@ TEST_F(MDL_test, concurrent_exclusive_sh EXPECT_NE(m_null_ticket, m_request.ticket); mdl_thread.join(); - m_mdl_context.release_all_locks_for_name(m_request.ticket); + m_mdl_context.release_transactional_locks(); } === modified file 'unittest/gunit/mdl_mytap-t.cc' --- a/unittest/gunit/mdl_mytap-t.cc 2010-11-18 16:34:56 +0000 +++ b/unittest/gunit/mdl_mytap-t.cc 2010-11-19 12:34:44 +0000 @@ -248,7 +248,6 @@ protected: void die_when_m_tickets_nonempty(); void die_when_holding_global_shared_lock(); void construct_and_destruct(); - void factory_function(); void one_shared(); void one_shared_high_prio(); void one_shared_read(); @@ -394,7 +393,7 @@ void MDL_test::test_one_simple_shared_lo EXPECT_FALSE(m_mdl_context.try_acquire_lock(&request_2)); EXPECT_EQ(m_request.ticket, request_2.ticket); - m_mdl_context.release_all_locks_for_name(m_request.ticket); + m_mdl_context.release_transactional_locks(); EXPECT_FALSE(m_mdl_context.has_locks()); } @@ -459,8 +458,7 @@ TEST_F(MDL_test, one_exclusive) is_lock_owner(MDL_key::GLOBAL, "", "", MDL_INTENTION_EXCLUSIVE)); EXPECT_TRUE(m_request.ticket->is_upgradable_or_exclusive()); - m_mdl_context.release_all_locks_for_name(m_request.ticket); - m_mdl_context.release_lock(m_global_request.ticket); + m_mdl_context.release_transactional_locks(); EXPECT_FALSE(m_mdl_context.has_locks()); } @@ -472,10 +470,8 @@ TEST_F(MDL_test, one_exclusive) TEST_F(MDL_test, two_shared) { MDL_request request_2; - m_request.init(MDL_key::TABLE, db_name, table_name1, MDL_SHARED, - MDL_TRANSACTION); - request_2.init(MDL_key::TABLE, db_name, table_name2, MDL_SHARED, - MDL_TRANSACTION); + m_request.init(MDL_key::TABLE, db_name, table_name1, MDL_SHARED, MDL_EXPLICIT); + request_2.init(MDL_key::TABLE, db_name, table_name2, MDL_SHARED, MDL_EXPLICIT); EXPECT_FALSE(m_mdl_context.try_acquire_lock(&m_request)); EXPECT_FALSE(m_mdl_context.try_acquire_lock(&request_2)); @@ -525,8 +521,8 @@ TEST_F(MDL_test, shared_locks_between_co EXPECT_TRUE(mdl_context2. is_lock_owner(MDL_key::TABLE, db_name, table_name1, MDL_SHARED)); - m_mdl_context.release_all_locks_for_name(m_request.ticket); - mdl_context2.release_all_locks_for_name(request_2.ticket); + m_mdl_context.release_transactional_locks(); + mdl_context2.release_transactional_locks(); } @@ -551,8 +547,7 @@ TEST_F(MDL_test, upgrade_shared_upgradab upgrade_shared_lock_to_exclusive(m_request.ticket, long_timeout)); EXPECT_EQ(MDL_EXCLUSIVE, m_request.ticket->get_type()); - m_mdl_context.release_all_locks_for_name(m_request.ticket); - m_mdl_context.release_lock(m_global_request.ticket); + m_mdl_context.release_transactional_locks(); } @@ -657,7 +652,7 @@ TEST_F(MDL_test, concurrent_shared) release_locks.notify(); mdl_thread.join(); - m_mdl_context.release_all_locks_for_name(m_request.ticket); + m_mdl_context.release_transactional_locks(); } @@ -695,8 +690,7 @@ TEST_F(MDL_test, concurrent_shared_exclu EXPECT_FALSE(m_mdl_context.acquire_locks(&m_request_list, zero_timeout)); EXPECT_NE(m_null_ticket, m_request.ticket); - m_mdl_context.release_all_locks_for_name(m_request.ticket); - m_mdl_context.release_lock(m_global_request.ticket); + m_mdl_context.release_transactional_locks(); } @@ -727,7 +721,7 @@ TEST_F(MDL_test, concurrent_exclusive_sh EXPECT_NE(m_null_ticket, m_request.ticket); mdl_thread.join(); - m_mdl_context.release_all_locks_for_name(m_request.ticket); + m_mdl_context.release_transactional_locks(); } --===============5530919088949431592== MIME-Version: 1.0 Content-Type: text/bzr-bundle; charset="us-ascii"; name="bzr/tor.didriksen@stripped" Content-Transfer-Encoding: 7bit Content-Disposition: inline # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: tor.didriksen@stripped\ # p744i9hd2jyfrpfq # target_branch: file:///export/home/didrik/repo/trunk-bugfixing/ # testament_sha1: fccbc3f2f55de8a9a882ff0964aec7ef11089f4f # timestamp: 2010-11-19 13:35:00 +0100 # source_branch: file:///export/home/didrik/repo/5.5-bugteam-bug58137/ # base_revision_id: bjorn.munch@stripped\ # 8vlexlbxp1kan7pf # # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWYPgv1kAA6/fgEAYUHf//3/n 3kq////wYAcXz2xRQa0ESkgoSAjjJkyYjEwAmTBMgBowjAEMAkiTVPCYk80RqmjT1PSGgeoNMjT1 GCaZMIOMmTJiMTACZMEyAGjCMAQwDU9RI9T1MhoGgAAAAAAAADjJkyYjEwAmTBMgBowjAEMAkkCa AEaACaNMSahpiANNNNDTTIsMMX3jIQN1dZNg2gun0MzTAog4O9D0x0XtahmQLRMK9TBsaTm2UVFY 1FEZyhkDhCo0L8VUmGZmQDMfD3CXxhKxxbXB+qhEYwi0WLpF+ZoTJjnlC4D9QUWili1LLpgEQSoh 8QFl8lK2nHUdyXgBE3uHg66/Hp4qUg0qpk4wUhU4v3KUmYyWTmHnWWUOfh5IkySyD5IDAM3s/Vce wDmGZBzWlw85hD1BpMj1h3Bs/lm+AxuFif4Af5SubHSPEqD4+Qjb1q+UlhHXX+3hVaVJgmgG7JFC caT+09PB7DMg7lwKayhX/Dh2FCTszJaGQQk6dgh/XsKGFvEfKUSIgEEBOiuw5kTYhhwxDgMPKdSe ML2DgcPMWChMOT8ShyjVI8x5P7jOJPGMa2rfKQUlCqKt+LwD8KTIY3mfCogZJxcUgFTk9aGQp04E REgnspJZqrmVBiis2hn1Z9ecqrB1Y7NccNqq5WPEtTF6mxdWbDT9CC22IqWttE3xzHyO8eAt+BgM JVmycdhuokFFk85cErmJUk1oeKqJUdAoEOK5mNcHlcYENZFzDhDlpKx4aYlBaqpwVrM6rYHDJ5TO RWUEbZQkIfWVsYsiY/a8HUUJG3EQ99QiUFKDBEZXscJPTMtQUDT0zwPmEjA52hAeBbjhiUkJJcjI SpgCg0Q6SaghwpdMIixWywmGpdQlFoxbOqix0888SeckFijjExH2bj5kX30rLdAxGpGyYvNaugVG jBF9dAXFuUiOYxjMO8YJ67drnlGfwEYRTPJ8nQVeVxmzIeZg+i7LO+bW5OfjEgZGZ4MQURxfKwg+ OTwqUjCudF9iwOys1LwVlsDRja0Gxa9qaxxgF4wyExNgjErmUY1jmGZ1kSZPAGMNHLbkYcxF1lZo Bpgz1LB6syaIXuCDkNJoBSKVDUZ/rQL8w09dSsWI4ZmWxNl7V3vXiopHzDuO44w2Kbi5brWGGYZu oORR7EQHRgqe1APzhPR3WhZPnVFKNfetyIZkOdqK/cFaHAKkeLA0m5gu8JDvgeIrCIRXQbqkEybF UBgEYl5uEaHyzKkXvVcm7z6J2kF6hBIIm1NwiDxRQHIAb1A8HlHKYpEFFAek8yQEzyPR59T7D/rQ 9J+j68vQgJIDjN2/2zRFPpQHIyRX0qOLICFliCtAalJOMVx0Gb7vwi9j3H5GwbaZbQsJ1HA5rMDf m9fegX6oJjFI1R70HExrIlri5pywPfyDgHHlFUQDnQDoC1AYbBBBAX6NJWseDAvKDfEQthcidEh6 iIjcLwrHxJVXgtQakhUoWNG8oB/bgRWdIG/JxsugxTS2s7hxScj9qeqrU6/Fk69WCYN6A3uQFx3l pfddm4Stazrw8cO5ufycdkB4hoBOD3pkGrftcR7m7t8F1B1GKpFvUkCeEeYF2G+fjqV5rBrwbiHz W5ULdbuecO4KRHmI6w9BQPSbYF/geU1VAGDeA3kvARZ4mZCOGAxuziNhdMpcCWpfnWkTRcJwV6DT WETLWLPm78Ajt38Z8qmQyA9BNe3sLSl1/7PwVSx1FysXMRKpuCrctwhkB4gvNG8O4LhXOIDEBBvQ DLaihTQDCuCSAzrooT19LkBAKy37ADQHYdw4oBl3rsfBqwCI57M1yRutNe+vylIK9AclbU+aIpqE ygkMIIgWKaSnFFiDXTODLGmKApCM4gdOyGVlskBPkIInYmEjZAQTHH6kj/IBhVKa8nq2i63v5LOI y1MmREJ+xeFQjoXhdrnSwQQdPWah+sMfiVbQwbJyQ5MkjrpQHFARQcTSY9HBSQ6AqlmZaK42uxET JPZfUgHLODUoDNK9ASBXw2uCxUiZUlzLnKr2sBMTNXVUlZQaSBwYZAScRTxZwf6n5rpSwHCBwqfX VnkuF43NAdjIGUPTiK1TQDOhkqYIy1hrDls7w45lq71q7FuDguV4vvVKKTA9BFWJkCq3LY5zcVAP WdhFKurcI/8XckU4UJCD4L9Z --===============5530919088949431592==--