List:Commits« Previous MessageNext Message »
From:Luis Soares Date:November 18 2010 3:51pm
Subject:bzr commit into mysql-trunk branch (luis.soares:3351) Bug#58160
View as plain text  
#At file:///home/lsoares/Workspace/bzr/work/bugfixing/58160/mysql-trunk-bugfixing/ based on revid:alexander.nozdrin@stripped

 3351 Luis Soares	2010-11-18
      BUG#58160: Incorrect behaviour of rpl_chage_master
      
      rpl_change_master was not resetting the master_retry_count
      at the end of the test. Thence it would leave retry_count
      with a huge value, which could cause other tests executing
      after it to time out.
      
      We fix this by resetting the value before the 
      rpl_change_master test ends.
     @ mysql-test/suite/rpl/t/disabled.def
        Removing the entry from the list of disabled tests.

    modified:
      mysql-test/suite/rpl/r/rpl_change_master.result
      mysql-test/suite/rpl/t/disabled.def
      mysql-test/suite/rpl/t/rpl_change_master.test
=== modified file 'mysql-test/suite/rpl/r/rpl_change_master.result'
--- a/mysql-test/suite/rpl/r/rpl_change_master.result	2010-08-05 17:45:25 +0000
+++ b/mysql-test/suite/rpl/r/rpl_change_master.result	2010-11-18 15:51:24 +0000
@@ -64,10 +64,13 @@ CHANGE MASTER TO master_connect_retry= 1
 ### stop slave server
 ### start slave server
 include/start_slave.inc
+include/stop_slave.inc
+CHANGE MASTER TO master_retry_count=10;
 CHANGE MASTER TO master_retry_count='a';
 ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''a'' at line 1
 CHANGE MASTER TO master_retry_count=-1;
 ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-1' at line 1
+include/start_slave.inc
 stop slave;
 drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
 reset master;

=== modified file 'mysql-test/suite/rpl/t/disabled.def'
--- a/mysql-test/suite/rpl/t/disabled.def	2010-11-12 11:37:06 +0000
+++ b/mysql-test/suite/rpl/t/disabled.def	2010-11-18 15:51:24 +0000
@@ -10,7 +10,6 @@
 #
 ##############################################################################
 
-rpl_change_master         : Bug#58160 2010-11-12 alik Incorrect behaviour of rpl_chage_master
 rpl_row_create_table      : Bug#51574 2010-02-27 andrei failed different way than earlier with bug#45576
 rpl_spec_variables        : BUG#47661 2009-10-27 jasonh rpl_spec_variables fails on PB2 hpux
 rpl_log_pos               : BUG#55675 2010-09-10 alfranio rpl.rpl_log_pos fails sporadically with error binlog truncated in the middle

=== modified file 'mysql-test/suite/rpl/t/rpl_change_master.test'
--- a/mysql-test/suite/rpl/t/rpl_change_master.test	2010-10-07 16:39:57 +0000
+++ b/mysql-test/suite/rpl/t/rpl_change_master.test	2010-11-18 15:51:24 +0000
@@ -232,6 +232,10 @@ if (`SELECT $retry_count5 <> $retry_coun
   -- die
 }
 
+# action: change the value back to the original one
+-- source include/stop_slave.inc
+-- eval CHANGE MASTER TO master_retry_count=$retry_count0
+
 ## assert that there is a parse error if not using a numerical value
 -- error ER_PARSE_ERROR
 CHANGE MASTER TO master_retry_count='a';
@@ -240,5 +244,15 @@ CHANGE MASTER TO master_retry_count='a';
 -- error ER_PARSE_ERROR
 CHANGE MASTER TO master_retry_count=-1;
 
+-- source include/start_slave.inc
+
+## assert that the test has cleaned itself up
+-- let $retry_count6= query_get_value(SHOW SLAVE STATUS, Master_Retry_Count, 1)
+if (`SELECT $retry_count6 <> $retry_count0`)
+{
+  -- echo Unexpected retry count value! Got: $retry_count6, expected: $retry_count0
+  -- die
+}
+
 -- source include/master-slave-reset.inc
 -- source include/master-slave-end.inc


Attachment: [text/bzr-bundle] bzr/luis.soares@oracle.com-20101118155124-6ri78epklofa2ztt.bundle
Thread
bzr commit into mysql-trunk branch (luis.soares:3351) Bug#58160Luis Soares18 Nov
  • Re: bzr commit into mysql-trunk branch (luis.soares:3351) Bug#58160Libing Song19 Nov