List:Commits« Previous MessageNext Message »
From:Marko Mäkelä Date:November 18 2010 8:30pm
Subject:Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)
View as plain text  
On Thu, Nov 18, 2010 at 09:39:15AM -0600, Kevin Lewis wrote:
>Most of the code I have worked on in the past used extra '-' before 
>macro variables and sometimes after.  Older preprocessors did not 
>enforce the scope of those variables.  They used to let all variables 
>take on the scope of the code they happen to be dropped into.

I am not aware of such preprocessors, and I have used various C 
development environments since 1991 or so.

Could you be thinking of variables that are introduced in the macro 
expansion? There are a few such variables in the InnoDB code base, in 
some data structure iterators. Heikki has used the 313 suffix for them, 
and the <valgrind/memcheck.h> uses the _qzz prefix, probably because it 
must try harder to avoid clashes.

Some 10 years ago, I wrote a translator that generated C code. I used 
the i prefix for some generated functions, which turned out to be a bad 
idea: i386 was a reserved symbol in the default GCC configuration.

	Marko
Thread
bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222) kevin.lewis18 Nov
  • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Vasil Dimov18 Nov
    • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Kevin Lewis18 Nov
    • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Kevin Lewis18 Nov
  • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Marko Mäkelä18 Nov
    • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Kevin Lewis18 Nov
      • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Calvin Sun18 Nov
      • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Marko Mäkelä18 Nov
        • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Sunny Bains18 Nov
          • RE: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Vladislav Vaintroub18 Nov
          • RE: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Vladislav Vaintroub18 Nov
          • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Sergei Golubchik18 Nov
          • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Marko Mäkelä22 Nov
          • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Marko Mäkelä22 Nov
        • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Sunny Bains18 Nov
      • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Marko Mäkelä18 Nov
      • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Calvin Sun18 Nov
    • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Kevin Lewis18 Nov
  • Re: bzr commit into mysql-5.5-innodb branch (kevin.lewis:3222)Marko Mäkelä18 Nov