On Thu, Nov 18, 2010 at 05:11:06 -0000, kevin.lewis@stripped wrote:
> #At file:///Users/kevinlewis/Work/Mysql/Bug56628/mysql-5.5-innodb/ based on
> revid:vasil.dimov@stripped
>
> 3222 kevin.lewis@stripped 2010-11-17
> RB://518 under review.
>
> Code cleanup related to patch for Bug56628. The general approach for InnoDB is
> to
> make a reference to each enum value whenever it is used in a switch statement.
> In addition, no default case should be used for switch statements on enum
> types.
> This assures that if there is ever any change in the enum values, the switch
> will need
> to change to reflect it since a compiler warning will occur.
> In this case, the enum row_type is declared in handler.h and could be changed
> for
> another storage engine. If so, a warning will occur in the InnoDB build.
>
> This patch introduces a series of macros to help consolidate the various
> warning
> messages. In the future, there will be more create option incompatibilities so
> these
> macros will help keep the code more readable.
>
> modified:
> storage/innobase/handler/ha_innodb.cc
> === modified file 'storage/innobase/handler/ha_innodb.cc'
> ---
> a/storage/innobase/handler/ha_innodb.cc revid:vasil.dimov@stripped
> +++
> b/storage/innobase/handler/ha_innodb.cc revid:kevin.lewis@stripped
> @@ -6496,8 +6496,7 @@ create_clustered_index_when_no_primary(
> /*****************************************************************//**
> Return a display name for the row format
> @return row format name */
> -
> -const char *get_row_format_name(
> +const char *get_row_type_name(
> /*============================*/
> enum row_type row_format) /*!< in: Row Format */
[...]
Please this the coding style here.
Also for the commit to appear on the bug report you must menton
"Bug#56628", not sure if it must be on the first line or not.
--
Vasil Dimov
moc.elcaro@stripped Software Developer @ Oracle/Innobase Oy
gro.DSBeerF@dv Committer @ FreeBSD.org
gro.d5v@dv Home @ Sofia, Bulgaria
Attachment: [application/pgp-signature]
