List:Commits« Previous MessageNext Message »
From:Georgi Kodinov Date:November 17 2010 1:26pm
Subject:bzr commit into mysql-5.5-bugteam branch (Georgi.Kodinov:3128) Bug#57559
View as plain text  
#At file:///home/kgeorge/mysql/work/B57559-5.1-bugteam/ based on revid:davi.arnaut@stripped

 3128 Georgi Kodinov	2010-11-17
      Bug #57559: Crash in Client plugin api
      
      The plugin code was releasing the plugin and 
      only then was reporting an error referencing it.
      Fixed by first reporting an error and then freeing up
      the plugin.

    modified:
      sql-common/client_plugin.c
=== modified file 'sql-common/client_plugin.c'
--- a/sql-common/client_plugin.c	2010-10-04 19:25:53 +0000
+++ b/sql-common/client_plugin.c	2010-11-17 13:26:11 +0000
@@ -176,11 +176,11 @@ err2:
   if (plugin->deinit)
     plugin->deinit();
 err1:
-  if (dlhandle)
-    dlclose(dlhandle);
   set_mysql_extended_error(mysql, CR_AUTH_PLUGIN_CANNOT_LOAD, unknown_sqlstate,
                            ER(CR_AUTH_PLUGIN_CANNOT_LOAD), plugin->name,
                            errmsg);
+  if (dlhandle)
+    dlclose(dlhandle);
   return NULL;
 }
 


Attachment: [text/bzr-bundle] bzr/georgi.kodinov@oracle.com-20101117132611-h1nmleg2s8mxdynh.bundle
Thread
bzr commit into mysql-5.5-bugteam branch (Georgi.Kodinov:3128) Bug#57559Georgi Kodinov17 Nov