Re: bzr commit into mysql-5.1-bugteam branch (nirbhay.choubey:3554) Bug#54899

[Nirbhay Choubey]

Hi Sergey,

Please see my comments in-line.

On Tuesday 16 November 2010 10:44 PM, Sergey Vojtovich wrote:
> Hi Nirbhay,
>
> a few use cases that used to work...
> Joro: do you think all of these points are valid?
>
> I run "mysql" with one-database option.
> I do not specify database name.
> I execute USE test.
> I get segmentation fault.
> I expect "Database changed".
>    

This happened as I missed out a check in my last patch,
the latest patch deals with this.

> I run "mysql" with one-database option.
> I specify "test" as database name.
> I execute USE non-existent-db.
> I get "ERROR 1049 (42000): Unknown database 'non-existent-db'".
> I expect "Database changed".
>    

This is expected, as we are running mysql_select_db with the
db name given with USE command, as against the older (pre-patch)
logic, where (in case of one-database), we used to skip mysql_select_db
call.

> I run "mysql" with one-database option.
> I specify "test" as database name.
> I execute CREATE DATABASE test1.
> I execute USE test1.
> I execute USE test1.
> I execute SELECT 1.
> I get "1".
> I expect "Ignoring query to other database".
>    

Again, a catch, fixed it in the latest patch.

> I run "mysql" with one-database option.
> I specify "test" as database name.
> I execute USE non-existent-db.
> I get "ERROR 1049 (42000): Unknown database 'non-existent-db'".
> I execute "\R \d>  ".
> I get "test>  ".
> I expect "test>  " (actually I would expect 'non-existent-db').
>    
I expect this, as prompt is created using current_db, and current_db
is not supposed to change after 'USE non-existent-db'.
> I execute SELECT 1.
> I get "Ignoring query to other database".
> I expect "1" (actually I would expect 'Ignoring query to other database').
>    

This is again an expected behavior, as one-database filtering is decided
based on the database name provided in the 'USE' command, which is
'non-existent-db' in this scenario.

Best,
Nirbhay

> Regards,
> Sergey
>