List:Commits« Previous MessageNext Message »
From:Mats Kindahl Date:November 16 2010 8:14am
Subject:Re: bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124)
Bug#58173
View as plain text  
On 11/16/2010 07:31 AM, Alexander Nozdrin wrote:
> Hi Mats,
>
> thank you for working on this. I have one small note (see below),
> otherwise I think, the patch is Ok.
>
> On 15.11.2010 18:17, Mats Kindahl wrote:
>>   static int
>> -fn_expand(const char *filename, const char **filename_var)
>> +fn_expand(const char *filename, char result_buf[FN_REFLEN])
>
> I would expect the second argument to be declared like
> 'char *result_buf':
> +fn_expand(const char *filename, char *result_buf)

OK, I'll change it.

> Not sure if all compilers are happy with that 'char arg[N]' declaration.

That would surprise me a lot, it's been in ANSI-C since the beginning.

/Matz



Thread
bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124) Bug#58173Mats Kindahl15 Nov
Re: bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124)Bug#58173Alexander Nozdrin16 Nov
  • Re: bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124)Bug#58173Mats Kindahl16 Nov
Re: bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124)Bug#58173Dmitry Lenev16 Nov
  • Re: bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124)Bug#58173Mats Kindahl16 Nov