| List: | Commits | « Previous MessageNext Message » | |
| From: | Alexander Nozdrin | Date: | November 16 2010 6:31am |
| Subject: | Re: bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124) Bug#58173 | ||
| View as plain text | |||
Hi Mats, thank you for working on this. I have one small note (see below), otherwise I think, the patch is Ok. On 15.11.2010 18:17, Mats Kindahl wrote: > static int > -fn_expand(const char *filename, const char **filename_var) > +fn_expand(const char *filename, char result_buf[FN_REFLEN]) I would expect the second argument to be declared like 'char *result_buf': +fn_expand(const char *filename, char *result_buf) Not sure if all compilers are happy with that 'char arg[N]' declaration.
| Thread | ||
|---|---|---|
| • bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124) Bug#58173 | Mats Kindahl | 15 Nov |
| • Re: bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124)Bug#58173 | Alexander Nozdrin | 16 Nov |
| • Re: bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124)Bug#58173 | Mats Kindahl | 16 Nov |
| • Re: bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124)Bug#58173 | Dmitry Lenev | 16 Nov |
| • Re: bzr commit into mysql-5.5-bugteam branch (mats.kindahl:3124)Bug#58173 | Mats Kindahl | 16 Nov |
