List:Commits« Previous MessageNext Message »
From:Dmitry Lenev Date:November 15 2010 11:10am
Subject:Re: bzr commit into mysql-5.5-runtime branch (jon.hauglid:3184)
Bug#57663
View as plain text  
Hello Jon Olav!

Here are my comments about your patch:

* Jon Olav Hauglid <jon.hauglid@stripped> [10/11/15 13:01]:
> #At file:///export/home/x/mysql-5.5-runtime-prereq/ based on
> revid:kostja@stripped
> 
>  3184 Jon Olav Hauglid	2010-11-15
>       Bug #57663 Concurrent statement using stored function and DROP DATABASE
>                  breaks SBR
>       
>       This pre-requisite patch removes obsolete and dead code used to remove
>       raid subdirctories and files during DROP DATABASE code.
             ^^^^^^^^^^^^^           ^^^^^^
             subdirectories?         in?

>       
>       Other parts of the raid code have already been removed in WL#5498.

You can also mention that support for MyISAM raid tables was removed in 5.0.

> === modified file 'sql/sql_db.cc'
> --- a/sql/sql_db.cc	2010-11-12 12:56:21 +0000
> +++ b/sql/sql_db.cc	2010-11-15 09:49:31 +0000
> @@ -932,8 +932,7 @@ exit:
>  }
>  
>  /*
> -  Removes files with known extensions plus all found subdirectories that
> -  are 2 hex digits (raid directories).
> +  Removes files with known extensions.
>    thd MUST be set when calling this function!
>  */
>  
> @@ -945,7 +944,6 @@ static long mysql_rm_known_files(THD *th
>    ulong found_other_files=0;
>    char filePath[FN_REFLEN];
>    TABLE_LIST *tot_list=0, **tot_list_next_local, **tot_list_next_global;
> -  List<String> raid_dirs;
>    DBUG_ENTER("mysql_rm_known_files");
>    DBUG_PRINT("enter",("path: %s", org_path));
>  

...


IMO it also makes sense to remove "level" argument from
mysql_rm_known_files(). With removal of raid support from
DROP DATABASE it becomes unnecessary.

Otherwise, I am OK with your patch and think that it can
be pushed after considering the above suggestions.

-- 
Dmitry Lenev, Software Developer
Oracle Development SPB/MySQL, www.mysql.com

Are you MySQL certified?  http://www.mysql.com/certification
Thread
bzr commit into mysql-5.5-runtime branch (jon.hauglid:3184) Bug#57663Jon Olav Hauglid15 Nov
  • Re: bzr commit into mysql-5.5-runtime branch (jon.hauglid:3184)Bug#57663Dmitry Lenev15 Nov